Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.4.0 breaks Java 8 support #1119

Open
theangrydev opened this issue Apr 17, 2024 · 4 comments
Open

4.4.0 breaks Java 8 support #1119

theangrydev opened this issue Apr 17, 2024 · 4 comments

Comments

@theangrydev
Copy link
Contributor

.m2/repository/com/github/jknack/handlebars/4.4.0/handlebars-4.4.0.jar(com/github/jknack/handlebars/Context.class)
[ERROR] class file has wrong version 61.0, should be 52.0

@jonatan-ivanov
Copy link

It seems the Java baseline was changed here: 70d9261.
As a user of handlebars and a maintainer of a project (micrometer-docs-generator) that uses it, I find quite unfortunate that the Java baseline was changed in a minor version and that the release notes does not mention this rather important detail.

@nealeu
Copy link

nealeu commented Jul 12, 2024

It breaks a lot. "Upgrade to Spring 6" means javax -> jakarta! That should have been a major version bump!

@jonatan-ivanov
Copy link

I think it is still possible to fix this by re-releasing

  • 4.3.1 as 4.5.0
  • 4.4.0 as 5.0.0

@jknack what do you think?

@nealeu
Copy link

nealeu commented Jul 13, 2024

The above suggestion is a really good idea. It's relatively simple to execute, and would clean up a lot of dependabot failures.

And, many thanks for providing us with a great Handlebars library. It is much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants