Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jj config set --repo user '{ name = "Some One", email = "[email protected]" }' creates an invalid configuration file #5281

Closed
forivall opened this issue Jan 6, 2025 · 1 comment

Comments

@forivall
Copy link

forivall commented Jan 6, 2025

Description

Using a toml inline table for local repo user configuration creates a broken configuration file.

Steps to Reproduce the Problem

  1. Run jj config set --repo user '{ name = "Some One", email = "[email protected]" }'
  2. Use any other jj command.

Expected Behavior

The jj command should work, and the configured inline user table should work

.jj/repo/config.toml

user = {name = "Some One", email = "[email protected]"}

Actual Behavior

Config error: Value not found for user.name
For help, see https://jj-vcs.github.io/jj/latest/config/.

I had to manually edit the file to revert the change to a regular TOML table. (I wanted to create a single command or alias which uses a single jj command to be able to set my per-repo user, as a workaround for #5280)

Specifications

  • Platform: macOS 15.2
  • Version: jj 0.25.0
@yuja
Copy link
Contributor

yuja commented Jan 7, 2025

The underlying issue (or design decision) is the same as #5255

@yuja yuja closed this as completed Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants