-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FR: Allow for setting --reversed
globally in the config file
#5203
Comments
I don't think this will be possible, see #1509. You can always use a custom log alias for it though. |
And it's unlikely we'd want to see |
I do think it's useful in both those cases: I think the underlying point to my request -- trying to take it from your perspective -- is that if you're printing it straight to console having the most recent things, However, I can also see that, using the tool in a script or pipeline to head/less or something, it's easier/preferable to put the most recent at the top. The semi-underlying issue being that, if you run So we come back around to, maybe I'm just a minority, but, considering you advertise the option in the docs, it's really really helpful when taking a quick look around with I'm closing the issue myself, but noting that while I think |
Just to expand on Philip's "alias" suggestion (sorry if you already figured this out), that would be: [aliases]
logr = ["log", "--reversed"]
evologr = ["evolog", "--reversed"] # Once implemented
[ui]
default-command = ["logr"] Then, you can use One upside of relying on aliases is that if you mention One unfortunate downside of aliases is that they currently mess up shell completion, at least as of a few weeks ago. I believe this is being worked on, so I might be out of date; either way, the hope is that this will be fixed at some point in the future. |
Just to be clear, I meant it would be unlikely because of performance reasons. And the UI cost we would have to pay is that we would need |
Actually, I was going to change the default for git-branchless to have a I do agree that reversing the output makes sense for a certain class of user's workflows (including me), although I'm sympathetic to the "UI cost" argument.
[observation] I'm not sure if that suggestion was originally meant to advocate for reversing vs not reversing, vs just showing a helpful practical example of configuring your log output. I agree that the documentation sounds like it's recommending it as the default 👀.
One of the differences between git-branchless and jj that's relevant here is that git-branchless's log output by default tries to limit it to just "your" work, rather than all nodes, so it makes more sense to reverse the output via a configuration option.
@barakmich Sorry to hear this. I don't think it was necessary to close the issue based on the discussion comments so far, which is perhaps a cultural difference for those inside and outside the project? For this discussion, I'll reopen it for now to invite commentary from anyone else who may be interested in providing their feedback.
I have found that many issues and proposals on fairly "basic" things get a lot of discussion about the topic itself, but also —
I think this is to be expected for a project at jj's stage, where not all of the design and UI principles have been fully established.
Was that in line with your expectations for the project? (You might also have just gotten unlucky with two immediate negative comments?) Do you think it's possible to convey those expectations to new users (perhaps via a comment in the feature request template)? |
That's also true for |
--reversed
globally in the config file--reversed
globally in the config file
@barakmich I'm curious if you think adopting an alias (as described in #5203 (comment)) would work for your workflow? That's probably what I would do. |
Is your feature request related to a problem? Please describe.
I set my
ui.default_command
to belog --reversed
(even as suggested in the documentation) and I really like the reversed style. While there's also recent work related to reversing (eg, #5170), it would be nice to make reversing log order a global option, especially for when I'm runningjj log -r QUERY
and then forget to add--reversed
every time.Describe the solution you'd like
A configuration option for what seems to eventually be a family of
--reversed
flags, to invert their behavior. Some examples include:Or if not globally, a consistent flag for each subcommand
(but it feels more
ui
to me 🤷)The text was updated successfully, but these errors were encountered: