Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: free pydantic version #6150

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

chore: free pydantic version #6150

wants to merge 5 commits into from

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Mar 7, 2024

Goals:

  • resolves #ISSUE-NUMBER

  • ...

  • ...

  • ...

  • ...

  • check and update documentation. See guide and ask the team.

@github-actions github-actions bot added size/XS area/setup This issue/PR affects setting up Jina labels Mar 7, 2024
This was linked to issues Mar 7, 2024
Support docarray pydantic v2 #6086
Open
Will the Pydantic dependency be upgraded in the future?Currently, due to version issues, some third-party packages are incompatible. #6125
Open
@codecov Codecov
Copy link

codecov bot commented Mar 7, 2024 •
edited

Codecov Report

Attention: Patch coverage is 10.44776% with 60 lines in your changes are missing coverage. Please review.

Project coverage is 59.36%. Comparing base (176f953) to head (bbd9b4b).

Files Patch % Lines
jina/_docarray_legacy.py 0.00% 16 Missing ⚠️
...ina/serve/runtimes/gateway/graph/topology_graph.py 12.50% 7 Missing ⚠️
...ve/runtimes/gateway/http_fastapi_app_docarrayv2.py 0.00% 7 Missing ⚠️
jina/serve/runtimes/head/request_handling.py 12.50% 7 Missing ⚠️
jina/serve/runtimes/worker/http_fastapi_app.py 0.00% 7 Missing ⚠️
jina/serve/runtimes/worker/http_sagemaker_app.py 0.00% 7 Missing ⚠️
jina/serve/runtimes/worker/request_handling.py 12.50% 7 Missing ⚠️
jina/_docarray.py 66.66% 1 Missing ⚠️
jina/serve/executors/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #6150       +/-   ##
===========================================
- Coverage   75.02%   59.36%   -15.66%     
===========================================
  Files         152      151        -1     
  Lines       14100    14091        -9     
===========================================
- Hits        10578     8365     -2213     
- Misses       3522     5726     +2204
Flag Coverage Δ
jina 59.36% <10.44%> (-15.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality labels Mar 7, 2024
@JoanFM JoanFM force-pushed the chore-free-Pydantic-version branch from 62f6c98 to ecdf2b6 Compare March 7, 2024 09:13
@github-actions github-actions bot added size/M area/testing This issue/PR affects testing labels Mar 7, 2024
@TamiasSibiricus TamiasSibiricus mentioned this pull request Apr 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanxiao hanxiao Awaiting requested review from hanxiao hanxiao will be requested when the pull request is marked ready for review hanxiao is a code owner

@nan-wang nan-wang Awaiting requested review from nan-wang nan-wang will be requested when the pull request is marked ready for review nan-wang is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/setup This issue/PR affects setting up Jina area/testing This issue/PR affects testing size/M size/S size/XS
Projects
None yet
Milestone
No milestone
1 participant
@JoanFM