Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log X-Forwarded-For Header #2312

Open
dkazantzas opened this issue May 28, 2024 · 1 comment
Open

Log X-Forwarded-For Header #2312

dkazantzas opened this issue May 28, 2024 · 1 comment

Comments

@dkazantzas
Copy link

Currently, requests containing an X-Forwarded-For header are not logged correctly, as the IP of the Proxy server is logged instead of the IP of original client

@vbakke
Copy link

vbakke commented Oct 22, 2024

Make sure you only log X-Forwarded-For if, and only if, Yopass is configured to be behind a trusted proxy.

If you trust X-Forwarded-For blindly you only log the IP addresses of the honest people. It is the other ones you want correct IP addresses from...

The proxy Caddy Server seems to have a sensible approach to this: https://caddyserver.com/docs/caddyfile/directives/reverse_proxy#defaults

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants