Skip to content

JsonLdParser is trying to parsing invalid data #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
stargt opened this issue Jan 21, 2023 · 1 comment
Open

JsonLdParser is trying to parsing invalid data #43

stargt opened this issue Jan 21, 2023 · 1 comment

Comments

@stargt
Copy link

stargt commented Jan 21, 2023 •
edited
Loading

An URL such as https://www.instagram.com/p/CmHTCMoJSV5/ emits empty string for data because the result of document?.head ?.querySelector("script[type='application/ld+json']") is <html script> at the following method in JsonLdParser.
It produces an exception, FormatException: Unexpected end of input (at character 1)

metadata_fetch/lib/src/parsers/jsonld_parser.dart

Lines 18 to 27 in 0ae3094

dynamic _parseToJson(Document? document) {
final data = document?.head
?.querySelector("script[type='application/ld+json']")
?.innerHtml;
if (data == null) {
return null;
}
var d = jsonDecode(data);
return d;
}

@stargt
Copy link
Author

stargt commented Jan 21, 2023

How about changing date == null to data?.isNotEmpty != true?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stargt