Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: config/rotate with a bad current token returns the wrong error #93

Open
TJM opened this issue May 4, 2023 · 0 comments
Open

test: config/rotate with a bad current token returns the wrong error #93

TJM opened this issue May 4, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@TJM
Copy link
Contributor

TJM commented May 4, 2023

https://github.com/jfrog/artifactory-secrets-plugin/pull/88/files/4ffd1cba0391435ed41c7067081c3e565fd26eae#r1184453545

This is a matter of opinion, I think that it should contain "that" error, but it does not. It returns the error about the certificate instead. I want to adjust this in a future MR.. trying to not change a bunch of code while writing the tests ;)

I think I want to "return" the correct error (error parsing existing access token) ... maybe including the reason (could not get the certificate). I was just not sure how I wanted to handle it just yet. Trying to emulate these error cases is kinda hard. I think a pure mock test may actually be easier here.

@alexhung alexhung added the enhancement New feature or request label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants