Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API and algorithm structure unification #2

Open
jfpettit opened this issue Apr 24, 2020 · 1 comment
Open

API and algorithm structure unification #2

jfpettit opened this issue Apr 24, 2020 · 1 comment
Assignees
@jfpettit
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jfpettit
Copy link
Owner

Algorithms in qpolgrad have been organized to define functions for loss calculation. Those functions are then called in the update function for the algorithm. A2C and PPO need to be brought up to that same structure.

Specifically:

  • Define compute_policy_loss and compute_value_loss functions in A2C and PPO.
  • Modify the update rules for both algorithms to call the loss computation functions.
  • Update docstrings to reflect your changes! If there aren't docstrings (sorry), add them!

👍
@jfpettit jfpettit added help wanted Extra attention is needed good first issue Good for newcomers labels Apr 24, 2020
@jfpettit jfpettit self-assigned this May 7, 2020
@jfpettit
Copy link
Owner Author

jfpettit commented May 7, 2020

Working on this. Converting code to PyTorch Lightning for consistency in structure and for the excellent automated capabilities Lightning offers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jfpettit jfpettit

Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jfpettit