Fixes #11763 - Race condition in QoSHandler. #11772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now using a read-write lock to atomically execute expire(). This guarantees that there are no races with resume(). The concurrency between handle() and resume(), which should be the most common case, is handled by atomic data structures. Signed-off-by: Simone Bordet <[email protected]>
lorban
previously approved these changes
May 9, 2024
gregw
requested changes
May 13, 2024
There was a problem hiding this comment.
I've found that if one synchronization mechanism doesn't prevent a race, then it is rarely fixed by adding yet another. The use of read/write lock and an atomic is strange and a bit confusing. I think I understand what it is doing, but at the very least it needs a lot more javadoc explaining the race and how this fixes it.
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/handler/QoSHandler.java
Show resolved
Hide resolved
Signed-off-by: Simone Bordet <[email protected]>
lorban
approved these changes
May 13, 2024
gregw
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now using a read-write lock to atomically execute expire().
This guarantees that there are no races with resume().
The concurrency between handle() and resume(), which should be the most common case, is handled by concurrent data structures.