You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
What happened: When upgrading the master and worker instance poolstarmak clusters apply --infrastructure-only ran the convergence code even though there were infrastructure changes which seems to contradict this issue
What you expected to happen: tarmak clusters apply --infrastructure-only should not check for convergence
I think we need a check here to not run the convergence code when infrastructure only has been specified. However, we want it so if a user explicitly asks for wait for convergence even when specifying infrastructure only then it happens as it's a useful way of checking whether all wings are running the latest puppet without triggering them. That is useful at the end of the playbook referenced in the issue
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
kind/bugCategorizes issue or PR as related to a bug.
Is this a BUG REPORT or FEATURE REQUEST?:
/kind bug
What happened: When upgrading the master and worker instance pools
tarmak clusters apply --infrastructure-only
ran the convergence code even though there were infrastructure changes which seems to contradict this issueWhat you expected to happen:
tarmak clusters apply --infrastructure-only
should not check for convergenceHow to reproduce it (as minimally and precisely as possible): follow https://playbooks.jetstack.io/tarmak/upgrading-instance-pool.html after changing the sizes of all instance pools
Environment:
kubectl version
): 1.11.5The text was updated successfully, but these errors were encountered: