Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

supports test-results panel and refactor output settings #1087

Merged
merged 13 commits into from Nov 2, 2023
Merged

supports test-results panel and refactor output settings #1087

merged 13 commits into from Nov 2, 2023

Conversation

connectdotz
Copy link
Collaborator

@connectdotz connectdotz commented Oct 29, 2023 •
edited

This PR primarily focuses on enhancing support for the "TEST RESULTS" panel, with adjustments made to better align with VS Code's testing framework for output management.

Key Changes

  1. Added a new settings "jest.outputConfig": Consolidate all output settings into this workspace level setting (as the TEST RESULTS panel's "testing.openTesting" setting is), including moving the "revealOutput" from "jest.runMode"
  2. Adding a new output reveal type "error" to reveal output only when tests have errors.
  3. Refactor "JestTestRun" to ensure 1 TestRun per process. Introduced JIT run creation and delayed-close to make using runs easier for consumers.
  4. Refactor a few "helper" classes by splitting them into separate files, as they are becoming kitchen sinks...
  5. upgrade dependencies.

Related Issues

resolve #1051,
resolve #1071,
resolve #1073,
resolve #1074,
resolve #1076,
resolve #1060

@coveralls
Copy link

coveralls commented Oct 29, 2023 •
edited

Pull Request Test Coverage Report for Build 6723670100

  • 290 of 290 (100.0%) changed or added relevant lines in 15 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.008%) to 97.736%
Totals Coverage Status
Change from base Build 6605359998: -0.008%
Covered Lines: 3924
Relevant Lines: 3938
💛 - Coveralls

@connectdotz connectdotz merged commit 15b61f5 into jest-community:master Nov 2, 2023
13 of 14 checks passed
@connectdotz connectdotz deleted the outputConfig branch November 2, 2023 01:22
@connectdotz connectdotz restored the outputConfig branch November 2, 2023 02:10
@connectdotz connectdotz deleted the outputConfig branch November 2, 2023 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@connectdotz @coveralls