Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split project into multiple parts #33

Open
jacobp100 opened this issue Sep 26, 2017 · 2 comments
Open

Split project into multiple parts #33

jacobp100 opened this issue Sep 26, 2017 · 2 comments

Comments

@jacobp100
Copy link
Collaborator

This project has a lot of use cases outside of snapshot testing. For example, automating App Store screenshots, or to help with a design feedback flow.

Would you be interested in splitting this project into multiple smaller modules? I suggest:

  • A module to layout a React Tree
  • A module to render a laid out tree to SVG/other
  • A Jest snapshot plugin

We could use Lerna/yarn workspaces to keep them in the same repo.

@orta
Copy link
Member

orta commented Sep 26, 2017

Sure, yeah, I'm totally into this 👍

If you want to put in the time, I'd love to see it as a yarn workspace. FWIW, I wouldn't ever expect the results of this to be good enough for app store screenshots, but I admire the idea :D

@jacobp100
Copy link
Collaborator Author

I'll try and push something this week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants