Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add textbox custom command prompt #3548

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

yongjoon-km
Copy link

@yongjoon-km yongjoon-km commented May 5, 2024

  • PR Description
    Add multiline prompt for custom command named textbox. To confirm textbox prompt, ConfirmInEditor is used. Add sub-title to inform confirm key-binding.
    resolves Custom commands prompt type with multiline support #3476

  • Please check if the PR fulfills these requirements

  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • Docs (specifically docs/Config.md) have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

Add multiline prompt for custom command named textbox.
To confirm textbox prompt, ConfirmInEditor is used. Add sub-title to
inform confirm key-binding.
@@ -0,0 +1,151 @@
package helpers
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copy and paste lots from confirmation_helper.go
It has many functionalities about input, menu, and commit_message.
Please tell me some ideas on how to organize functions in confirmation_helpers.go and textbox_helpers.go. 🙇

@Djedouas
Copy link

Thanks for the PR!

It is exactly what I needed. Tested, works fine ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom commands prompt type with multiline support
2 participants