Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for additional geocoding services #62

Open
jessecambon opened this issue Jan 3, 2021 · 6 comments
Open

Add support for additional geocoding services #62

jessecambon opened this issue Jan 3, 2021 · 6 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@jessecambon
Copy link
Owner

jessecambon commented Jan 3, 2021

Instructions on how to add a geocoding service to the package are now here.

@jessecambon jessecambon added the help wanted Extra attention is needed label Jan 3, 2021
@maxachis
Copy link

maxachis commented Feb 7, 2021

If I could recommend a Geocoder service to add, may I suggest Mapbox API?

https://docs.mapbox.com/api/search/

@dieghernan
Copy link
Contributor

Hey! Glad to give Mapbox API a try, what I have seen so far is that there are two different endpoints:

https://docs.mapbox.com/api/search/geocoding/#endpoints

I can try mapbox.places as a stand-alone method (i.e. method="mapbox") if it is something that @jessecambon would like to explore. I think mapbox.places-permanent would be pretty much the same implementation, but maybe via another method (method="mapbox_permanent"¿?), and including batch geocoding.

@jessecambon
Copy link
Owner Author

jessecambon commented Mar 2, 2021

Hey @dieghernan that would be great. I'm assuming mapbox.places and mapbox.places-permanent have the same API parameters? If so, we could use method = 'mapbox' for both and then use a different variable to toggle the API url. For instance, the geocodio_v and iq_region variables in the geo() function are currently used for adjusting API urls for the Geocodio and Location IQ services.

Also, could you base your changes off the reverse-geocoding branch? I've restructured a few things in the package to accommodate reverse geocoding (added new reverse_geo and reverse_geocode functions) so using this branch as the base will make it easier to merge changes. I haven't pushed this branch into master just yet because there are a few minor things I want to clean up first. I just updated the instructions above to reflect the new code structure.

@dieghernan
Copy link
Contributor

dieghernan commented Mar 5, 2021

Quick list with potential geocoding services (this list would be updated in the future)

Geonames

Docs: http://www.geonames.org/export/geonames-search.html

See also {geonames} package: https://github.com/ropensci/geonames

This was referenced Mar 10, 2021
This was referenced Mar 23, 2021
@jessecambon jessecambon changed the title Add support for other geocoder services Add support for additional geocoder services Apr 12, 2021
@jessecambon jessecambon changed the title Add support for additional geocoder services Add support for additional geocoding services Aug 31, 2021
@moreron
Copy link

moreron commented Oct 23, 2021

Any chance of getting https://geocode.xyz added to the already impressive list? Thanks

@jessecambon
Copy link
Owner Author

@moreron The geocode.xyz service is now implemented on the geocode.xyz branch if you'd like to test it out

@jessecambon jessecambon added the enhancement New feature or request label Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants