Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mapbox fails with \t or \n in address #190

Open
LukasWallrich opened this issue May 17, 2023 · 1 comment
Open

mapbox fails with \t or \n in address #190

LukasWallrich opened this issue May 17, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@LukasWallrich
Copy link

When I use mapbox, the following gives an Error in curl::curl_fetch_memory(url, handle = handle) : URL using bad/illegal format or missing URL

tidygeocoder::geo(address = "Department \n Marburg", method = "mapbox")

I think this is because the address is inserted into the URL for mapbox, and api_url_modification() does rather little escaping. Maybe that could be made more robust?

@LukasWallrich LukasWallrich added the bug Something isn't working label May 17, 2023
@jessecambon
Copy link
Owner

Thanks, yes I think that's the issue as "\\n" in the address doesn't cause issues. One potential solution would be to replace lone \ characters with \\.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants