Update

Author: jerviscui

src/.editorconfig

@@ -1479,6 +1479,9 @@ dotnet_diagnostic.S1186.severity = error
 # S1206: "Equals(Object)" and "GetHashCode()" should be overridden in pairs
 dotnet_diagnostic.S1206.severity = error
 
+# "GC.Collect" should not be called
+dotnet_diagnostic.S1215.severity = error
+
 # Floating point numbers should not be tested for equality 浮点数不应测试相等性
 dotnet_diagnostic.S1244.severity = error
 

src/Tests/CollectionTest/ConditionalWeakTableTests.cs

@@ -1,64 +1,70 @@
+using System.Diagnostics.CodeAnalysis;
 using System.Runtime.CompilerServices;
 
 namespace CollectionTest;
 
 public static class ConditionalWeakTableTests
 {
+
+    #region Constants & Statics
+
+    [SuppressMessage("Critical Code Smell", "S1215:\"GC.Collect\" should not be called", Justification = "<Pending>")]
     public static void Test()
     {
+        //需要 release 下，start without debug
+
         var mc1 = new ManagedClass { I = 1 };
         var mc2 = new ManagedClass { I = 2 };
         var mc3 = new ManagedClass { I = 3 };
         var mc4 = new ManagedClass { I = 4 };
 
         var cwt = new ConditionalWeakTable<ManagedClass, ClassData>
-        {
-            { mc1, new ClassData() }, { mc2, new ClassData() }, { mc3, new ClassData() }, { mc4, new ClassData() }
-        };
+        { { mc1, new ClassData() }, { mc2, new ClassData() }, { mc3, new ClassData() }, { mc4, new ClassData() } };
 
         var wr2 = new WeakReference(mc2);
         mc2 = null;
 
         foreach (var ele in cwt)
         {
-            Console.WriteLine("{0} Data created at {1}", ele.Key.I, ele.Value.CreationTime);
+            Console.WriteLine($"{ele.Key.I} Data created at {ele.Value.CreationTime}");
         }
 
         GC.Collect();
 
         Thread.Sleep(100);
 
         var count = 10;
-        while (count-- > 0) //release 下运行
+        while (count-- > 0)
         {
             if (wr2.Target == null)
             {
                 Console.WriteLine("No strong reference to mc2 exists.");
             }
             else if (cwt.TryGetValue((ManagedClass)wr2.Target, out var data))
             {
-                Console.WriteLine("mc2 Data created at {0}", data.CreationTime);
+                Console.WriteLine($"mc2 Data created at {data.CreationTime}");
             }
             else
             {
                 Console.WriteLine("mc2 not found in the table.");
             }
 
-            if (cwt.TryGetValue(mc1, out var data2))
-            {
-                Console.WriteLine("mc1 Data created at {0}", data2.CreationTime);
-            }
+            //if (cwt.TryGetValue(mc1, out var data2))
+            //{
+            //    Console.WriteLine($"mc1 Data created at {data2.CreationTime}");
+            //}
 
             foreach (var ele in cwt)
             {
-                Console.WriteLine("{0} Data created at {1}", ele.Key.I, ele.Value.CreationTime);
+                Console.WriteLine($"{ele.Key.I} Data created at {ele.Value.CreationTime}");
             }
 
             Console.WriteLine("once");
             GC.Collect();
             Thread.Sleep(100);
 
-            //Release 输出：为什么只有 mc1 mc4 不被释放，
+            //? 为什么只有 mc1 mc4 不被释放，
+            //Release 输出：
             //1 Data created at 2022-09-13 17:38:19
             //2 Data created at 2022-09-13 17:38:19
             //3 Data created at 2022-09-13 17:38:19
@@ -71,23 +77,28 @@ public static void Test()
         }
     }
 
+    #endregion
+
     private class ManagedClass
     {
+
+        #region Properties
+
         public int I { get; set; }
+
+        #endregion
     }
 
     private class ClassData
     {
-        public DateTime CreationTime;
-
-        public object Data;
-
         public ClassData()
         {
             CreationTime = DateTime.Now;
             Data = new object();
         }
-    }
-}
 
+        public DateTime CreationTime;
 
+        public object Data;
+    }
+}

src/Tests/CollectionTest/Program.cs

@@ -1,11 +1,21 @@
+namespace CollectionTest;
 
+internal class Program
+{
 
-using CollectionTest;
+    #region Constants & Statics
 
-//SortedSetTests.Order_Test();
+    private static void Main(string[] args)
+    {
+        //SortedSetTests.Order_Test();
 
-//SortedListTests.Order_Test();
+        //SortedListTests.Order_Test();
 
-ConditionalWeakTableTests.Test();
+        ConditionalWeakTableTests.Test();
 
-Console.ReadLine();
+        Console.ReadLine();
+    }
+
+    #endregion
+
+}