Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inline images in parent message have the wrong content-disposition (attached) when replying #177

Open
molok opened this issue Jan 9, 2024 · 1 comment

Comments

@molok
Copy link

molok commented Jan 9, 2024

I receive a lot of emails with inline images (usually in the signature), when replying an email with inline images I've noticed that the MIME message generated by org-msg sets Content-Disposition as "attached" instead of "inline", this looks weird in clients like Outlook Web.

the only workaround I've found so far is to set

(setq mml-content-disposition-alist
          '((text (rtf . "attachment") (t . "inline"))
            (".*tmp.*cid.*image.*png" . "inline")
            (t . "attachment"))))

this way mml forces content-disposition inline for attachments with paths matching the ".*tmp.*cid.*image.*png"" regex, which matches where org-msg stores that kind of attachments on my machine.

I'm sure there are lots of way this can break, but at least it I won't spam my colleagues with "fake" attachments.

I'm using the latest org-msg, mu4e 1.10.8 and Emacs 29.1

@molok molok changed the title inline images in parent message became have the wrong content-disposition (attached) when replying inline images in parent message have the wrong content-disposition (attached) when replying Jan 9, 2024
jeremy-compostella added a commit that referenced this issue Jan 16, 2024
This addresses Issue #177.

Signed-off-by: Jeremy Compostella <[email protected]>
jeremy-compostella added a commit that referenced this issue Jan 16, 2024
This addresses Issue #177.

Signed-off-by: Jeremy Compostella <[email protected]>
@jeremy-compostella
Copy link
Owner

Is #178 working for you ?

jeremy-compostella added a commit that referenced this issue Jan 16, 2024
This addresses Issue #177.

Signed-off-by: Jeremy Compostella <[email protected]>
jeremy-compostella added a commit that referenced this issue Mar 19, 2024
This addresses Issue #177.

Signed-off-by: Jeremy Compostella <[email protected]>
peterhoeg pushed a commit to peterhoeg/org-msg that referenced this issue Apr 19, 2024
This addresses Issue jeremy-compostella#177.

Signed-off-by: Jeremy Compostella <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants