Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define what role should be assigned to the service principal in the documentation #374

Open
tgquan67 opened this issue Sep 29, 2022 · 6 comments
Labels
documentation A PR that adds to documentation - used by Release Drafter

Comments

@tgquan67
Copy link

Describe your use-case which is not covered by existing documentation.

In the prerequisites section of the documentation, it did not mention what kind of role or API permission should be assigned to the service principal. Is this an implicit requirement to assign the Owner role to it? And if that's the case, shouldn't we limit the amount of privilege this service principal is given to the bare minimum?

Reference any relevant documentation, other materials or issues/pull requests that can be used for inspiration.

No response

@tgquan67 tgquan67 added the documentation A PR that adds to documentation - used by Release Drafter label Sep 29, 2022
@timja
Copy link
Member

timja commented Sep 29, 2022

if you can figure out what the permission is required and add to the documentation that would be helpful.

Contributor definitely works.

You may be able to get away with Virtual Machine Contributor but that would need testing

@tgquan67
Copy link
Author

I guess I will need to test that out. Owner and Contributor are out, they give too much privilege.

@tgquan67
Copy link
Author

So far it's working for me by assigning the service principal with Virtual Machine Contributor on subscription scope and Contributor on a resource group scope (the resource group where the VMs are deployed). The network, subnet and security group were created beforehand when I was making the template, so I just reused those.

@timja
Copy link
Member

timja commented Oct 14, 2022

Why did you need Virtual Machine Contributor on the subscription scope?

@tgquan67
Copy link
Author

Err, in the documentation it did not mention the scope, so I assumed that it was on the subscription scope?

@timja
Copy link
Member

timja commented Oct 14, 2022

it should only need it on the resource group

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation A PR that adds to documentation - used by Release Drafter
Projects
None yet
Development

No branches or pull requests

2 participants