type hint and example out-of-sync

[castedo]

The target parameter of the GitClient.fetch method is Repo:

dulwich/dulwich/client.py

Line 925 in 50df0ca

target: Repo,

and porcelain.fetch calls the above function with the repo parameter of porcelain.fetch

dulwich/dulwich/porcelain.py

Line 1750 in 50df0ca

fetch_result = client.fetch(path, r, progress=errstream.write, depth=depth)

(via open_repo_closing which in this case is a no-op passthrough).

But the examples/memoryrepo.py is using a MemoryRepo argument for the target parameter:

dulwich/examples/memoryrepo.py

Line 20 in 50df0ca

fetch_result = porcelain.fetch(local_repo, sys.argv[1])

but MemoryRepo is not a subclass of Repo, only a BaseRepo. So this MemoryRepo object will get passed down into target which is typed to a Repo.

Not sure if this is an issue with the type hint or whether the example is showing something that sometimes fails at runtime.

Is it safe to use a MemoryRepo with GitClient.fetch?

[castedo]

Hmmmm, sorry I've messed up my description or I'm confused. I'm going to close this and then re-open if I find something real.

[castedo]

OK, I've updated the description of this issue to include a missing step. Sorry about the confusion.

I'm mainly just wondering if MemoryRepo is safe to use with GitClient.fetch.

And this might also be a type hint that needs updating.

[jelmer]

It should be safe to use MemoryRepo with GitClient.fetch, and the typehint should just be updated.

I don't think we have any explicit tests today that try to use GitClient.fetch with MemoryRepo though.

[jelmer]

Can you send a PR to fix the type hint?

[castedo]

Can you send a PR to fix the type hint?

OK, sounds good.