Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stored credentials not updating on logout #5500

Merged
merged 1 commit into from
May 14, 2024

Conversation

thornbill
Copy link
Member

Changes
Fixes the updated saved server credentials not being persisted to local storage when a user logs out

Issues
Fixes jellyfin/jellyfin#11598

@thornbill thornbill added the bug Something isn't working label May 13, 2024
@thornbill thornbill requested a review from a team as a code owner May 13, 2024 21:38
@thornbill thornbill added this to the v10.9.1 milestone May 13, 2024
@nielsvanvelzen
Copy link
Member

Shouldn't this target the release branch?

@thornbill
Copy link
Member Author

It doesn't really matter since we can go either direction, but yes. I didn't think about it until after I opened the PR and I have not had the chance to update it yet. 😅

@jellyfin-bot

This comment was marked as outdated.

@jellyfin-bot jellyfin-bot added the merge conflict Conflicts prevent merging label May 14, 2024
@thornbill thornbill changed the base branch from master to release-10.9.z May 14, 2024 17:48
@nielsvanvelzen nielsvanvelzen removed the merge conflict Conflicts prevent merging label May 14, 2024
@nielsvanvelzen nielsvanvelzen added the stable backport Backport into the next stable release label May 14, 2024
Copy link

sonarcloud bot commented May 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit d17c35a
Status ✅ Deployed!
Preview URL https://97d290e3.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs
View bot logs

@thornbill thornbill added this to In progress in Release 10.9.z via automation May 14, 2024
@thornbill thornbill merged commit ea8ceaa into jellyfin:release-10.9.z May 14, 2024
12 checks passed
Release 10.9.z automation moved this from In progress to Done May 14, 2024
@thornbill thornbill deleted the fix-logout-credentials branch May 14, 2024 21:22
joshuaboniface pushed a commit that referenced this pull request May 17, 2024
Fix stored credentials not updating on logout

Original-merge: ea8ceaa

Merged-by: thornbill <[email protected]>

Backported-by: Joshua M. Boniface <[email protected]>
@jellyfin-bot jellyfin-bot removed the stable backport Backport into the next stable release label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

[Issue]: WebUI does not load
3 participants