Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the new Server-Time header from KodiSyncQueue #918

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use the new Server-Time header from KodiSyncQueue #918

wants to merge 1 commit into from

Conversation

oddstr13
Copy link
Member

Fixes #916

@oddstr13 oddstr13 added bugfix needs-testing Some testing is requested/required before merging labels Sep 19, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 21.88%. Comparing base (6cc0bb6) to head (3c394bc).
Report is 21 commits behind head on master.

Files with missing lines Patch % Lines
jellyfin_kodi/library.py 0.00% 13 Missing ⚠️
jellyfin_kodi/jellyfin/http.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #918      +/-   ##
==========================================
- Coverage   21.90%   21.88%   -0.02%     
==========================================
  Files          63       63              
  Lines        8634     8641       +7     
  Branches     1587     1588       +1     
==========================================
  Hits         1891     1891              
- Misses       6722     6729       +7     
  Partials       21       21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oddstr13 oddstr13 force-pushed the pr-iso-server-time-1 branch from 3427ab6 to 3c394bc Compare September 20, 2024 22:22
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 20, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@oddstr13
Copy link
Member Author

Related PR in KodiSyncQueue: jellyfin/jellyfin-plugin-kodisyncqueue#95

@oddstr13 oddstr13 marked this pull request as ready for review September 20, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix needs-testing Some testing is requested/required before merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

save_last_sync try to convert HTTP date header with a localized python date-time parser which is incorrect
1 participant
@oddstr13