-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subtitles missing for BluRay discs #872
Comments
Unable to reproduce, seems to be working for me |
Anything further you need to debug the issue or steps i can take to fix it? It works with -- say -- ripped MKV's by the way, it has to be the backed up files of the BRD itself, are you using that? For myself I take MakeMKV and just click the Backup button. |
Yes, my test was made with a BDMV directory structure. |
Yep, any of the discs I try have this problem and (as it turns out) the audio track selection is having the identical issue but I didn't notice that before I titled the bug. I did do a little debugging (but I don't think I can personally fix it or anything). Regarding the audio track selections, it seems like an identical bug. A default selection is picked, it's often the wrong one (e.g. director's commentary), and then when I use the Kodi menus to try and select another track, they aren't there. Regarding the subtitles, the way my discs and Jellyfin are set up, it wants to stream the subtitles and not let them be downloaded. When you hit play, there's no valid selected subtitle stream index. The
Is there anything amiss here? |
If you're transcoding for whatever reason, then subtitles have to be chosen before the stream starts. They can't be adjusted after playback has started, because iirc that requires stopping and restarting the transcode stream. And currently, all BDMV files will trigger a transcode in Kodi. Not sure why yet. However, this behavior applies to all transcoded streams, not just BDMV sources. There's also quite a few quirks about using BDMV folder structure that aren't real well documented because nobody on the team really uses them. I have exactly 1 just because of trying to reproduce another bug that's specific to BDMVs (the above mentioned transcoding issue). |
Describe the bug
When playing from an unencrypted BluRay copy, subtitles are not available.
If using Jellyfin in the browser, there's no problem, it's in the Subtitles and can be toggled, but from Kodi (on OSMC) if you enable the subtitles nothing happens and if you search the subtitles there is only
None
.To Reproduce
Expected behavior
Subtitles can be enabled
Logs
Long log output from today, tried to play it twice
Screenshots
n/a
System (please complete the following information):
Additional context
Tried it with multiple TV shows and multiple other clients; all good except this plug-in.
Please feel free to give tips as to where to troubleshoot in the code, I may be able to pitch in with some guidance as to where to start.
Thanks for this great plugin! 🙏
The text was updated successfully, but these errors were encountered: