Skip to content
This repository has been archived by the owner on Oct 20, 2022. It is now read-only.

Zidoo Client Listing #143

Open
anthonylavado opened this issue Oct 4, 2022 · 6 comments
Open

Zidoo Client Listing #143

anthonylavado opened this issue Oct 4, 2022 · 6 comments

Comments

@anthonylavado
Copy link
Member

anthonylavado commented Oct 4, 2022

Opening an issue to continue discussion instead of staying in a commit


@Andy2244 Just regarding location, I would suggest replying in the pull request, instead of on the commit. Though commenting/replying on a commit is possible, it doesn't show up in the GitHub mobile app, and it's hard to keep track of. Replying on a Pull Request is what I believe to be the generally accepted way to comment, keeping the commit for line specific comments. Since this has grown much bigger, I am creating a separate issue entirely.

I will be clear and say that I had a much nicer and fuller response that I have been drafting since last night, but my motivation for it has quickly evaporated. There's also not much energy left over after work during the week - I do carry a full-time job and many others also have other commitments.

Let's just start from the top and go from there. I am choosing not to address anything else (including communication) at this time, in the hope that we can just move forward. Here's what I would be looking for:

  1. Would you be able to choose a new name for the client you are distributing? Ideally this takes the format of "_____ for Jellyfin" or it can also be an entirely unique name.
  2. Would you be able to choose a different/unique logo for your client?
  3. Please ensure that you are using a unique application ID for the client, that does not include the org.jellyfin namespace.
  4. Of course, please remain compliant with the GPL license for the application. This is just a reminder - to my quick review, you have remained compliant thus far.

Thank you.

anthonylavado referenced this issue Oct 4, 2022
Sync clients page with jellyfin-next
@Andy2244
Copy link
Contributor

Andy2244 commented Oct 4, 2022

  1. Would you be able to choose a new name for the client you are distributing? Ideally this takes the format of "_____ for Jellyfin" or it can also be an entirely unique name.

  2. Would you be able to choose a different/unique logo for your client?

Why does it always take a ping to the top, before i get any meaningful communication?
This is the first time anyone specifically told me what to actually change or what requirements i'm not meeting.

Ofc i can change the name and i already use a different installer logo?
I can try create a different logo and double check if i missed some locations its not displayed.

If that was all i needed to change, why would no one tell me this and instead just kick me out?
I don't care what name or logo i use, all i wanted is to bring Jellyfin to a new platform and for users to find this version.

@cvium
Copy link

cvium commented Oct 4, 2022

You do realize that both Bill and I are in the core team?

@Andy2244
Copy link
Contributor

Andy2244 commented Oct 4, 2022

You do realize that both Bill and I are in the core team?

Sure, what are you trying to say?

@anthonylavado
Copy link
Member Author

He's saying that they are also in "the top".

We've specifically created this new policy a few months ago as an extension of what was there before, because of this client. We've never run into this before, as most people just change the name right from the start. I'll also be honest and say all of this was at the bottom of my notifications.

At any rate, it's not visible, but we've used a lot of mental energy on this. I don't want to go back and forth any further on why or what.

I won't guarantee an immediate return to the list, but the changes above will bring things in line with the guidelines.

@Andy2244
Copy link
Contributor

Andy2244 commented Oct 4, 2022

At any rate, it's not visible, but we've used a lot of mental energy on this. I don't want to go back and forth any further on why or what.

as most people just change the name right from the start

At no point did anyone ask me to change the name or specifically pointed out that this was the main issue. As noted for the most part i suspected some problems with the logo. Yet no one asked me to change any logo, so ofc i thought its all fine after you added me to the client list.

How can i be expected to change something, if no one actually gives me a heads-up that something is still wrong with my client after months of being listed?
Its not that this was a ongoing/open PR, for me this "branding" issue was solved, since i never got any new/updated complaints about it.

Overall i'm just frustrated and disappointed, i was excited switching from OpenWRT to Jellyfin and adding to the project. I believe no dev i interacted with, really has some ill intent towards me or my work, yet i feel pushed into a corner, needing to defend myself and my work.
As a result i gave-up trying to upstream any changes, since as you noted the mental energy needed to argue on even the most basic PR is just too much.
I accepted this and moved on, yet i wished things could have gone differently.

@anthonylavado
Copy link
Member Author

I apologize for the appearance and how it looks, but as I mentioned, I won't be addressing anything further. Maybe some other time, but not now (or soon).

I've clearly listed what we'd be looking for, and I look forward to seeing the updates. If you need any clarification on any specific items, let me know.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

3 participants