Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Proper support for sway and wlroots-compatible compositors #113

Open
AZMCode opened this issue Jul 15, 2023 · 10 comments
Open

[REQUEST] Proper support for sway and wlroots-compatible compositors #113

AZMCode opened this issue Jul 15, 2023 · 10 comments
Labels
enhancement New feature or request

Comments

@AZMCode
Copy link
Contributor

AZMCode commented Jul 15, 2023

Currently the application only creates a window in wayland, and it is displayed as a regular window, not the desktop background.
Other background applications for wlroots-compatible compositors, like swaybg, use the wlr_layer_shell protocol (using the 'wallpaper' namespace), to properly set the window as the desktop background.

@AZMCode
Copy link
Contributor Author

AZMCode commented Jul 15, 2023

#111 would be covered by this

@AZMCode AZMCode changed the title Proper support for sway and wlroots-compatible compositors [REQUEST] Proper support for sway and wlroots-compatible compositors Jul 15, 2023
@AZMCode
Copy link
Contributor Author

AZMCode commented Jul 15, 2023

There is a library called gtk-layer-shell which allows you to call this interface through python.
Here's an example that could be adapted to fit into this

@jeffshee jeffshee added the enhancement New feature or request label Jul 19, 2023
@jeffshee
Copy link
Owner

Hi @AZMCode, thanks for bringing this to my attention. I wasn't aware of wlr_layer_shell protocol or the gtk-layer-shell library that you had mentioned. Hmm, interesting...

I'm considering giving gtk4-layer-shell a try. If it works as intended for most things, we can begin rewriting Hidamari in GTK4! This could be an exciting new direction. 😎

@AZMCode
Copy link
Contributor Author

AZMCode commented Jul 19, 2023

In any case while porting hidamari to GTK4 is plausible and probably for the best, gtk-layer-shell offers versions of the library for both GTK-3 and GTK-4, so that porting Hidamari to GTK-4 is probably outside the scope of this issue. Opening a new issue to track the porting of Hidamari to GTK-4 is probably for the best.

@AZMCode
Copy link
Contributor Author

AZMCode commented Jul 20, 2023

I'd love to work on a patch to add the GTK-3 version myself, but I've been having som e trouble getting the development environment set up. If you could please drop some instructions on how to build from source, it would be deeply appreciated.

@jeffshee
Copy link
Owner

Ok, but please give me some time, and I'll try to write the docs in this weekend!
Meanwhile, you can take a look at the AUR pkgbuild for some hint:
https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=hidamari

Build for Flatpak is more difficult to setup. Sometimes I couldn't get the vlc working properly, it's getting fragile and hard to maintain... Also, it takes so long to build the vlc module... (don't mind, just some rants)

@AZMCode
Copy link
Contributor Author

AZMCode commented Jul 21, 2023

Got it. I understand it's time consuming to do this, and this is volunteer work, so take your time. I'll do my best to hammer out a solution in my own spare time.

@jeffshee
Copy link
Owner

Docs for building is available here!
https://github.com/jeffshee/hidamari/blob/master/docs/development.md

@jeffshee
Copy link
Owner

jeffshee commented Sep 30, 2023 via email

@AZMCode
Copy link
Contributor Author

AZMCode commented Oct 3, 2023

Thanks, I'll keep it in mind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants