Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any Video does not look correct color-wise [X11/Ubuntu23.04/Nvidia] #77

Open
Tsubajashi opened this issue Jul 31, 2023 · 21 comments
Open
Labels
bug Something isn't working renderer Renderer related

Comments

@Tsubajashi
Copy link

Description
When a Video is played back through hanabi, it seems like the colors are not correct.
grafik
However, when played back directly through Clapper (built from source) it looks absolutely fine.
grafik

OS and Shell Information
Please provide your OS name and version, GNOME Shell version, and the session type (X11/Wayland).

  • OS: Ubuntu 23.04
  • GNOME Shell: 44.3
  • Session type: X11
  • GPU and Drivers: NVIDIA GeForce RTX™ 3080 / 535.86.05

Steps to Reproduce
Please provide the steps to reproduce the bug you are encountering.

  1. Pick any Videofile (i added the example clip in this bug report)
  2. Check your background video now
  3. See the wrong colors

Expected Behavior
It should look exactly like it does in Clapper.

Actual Behavior
Colors are completely wrong.

Additional Information
I'm not sure how to debug this, or which logs may be interesting. im happy to help, i just need a few pointers on what is needed to find out why this error seemingly exists.

The video in question, but any video has that same error: https://mylivewallpapers.com/anime/giyu-tomioka-kimetsu-no-yaiba-live-wallpaper/

@jeffshee
Copy link
Owner

jeffshee commented Aug 1, 2023

Hi @Tsubajashi,

Hmm, I couldn't reproduce this issue. I tried every option in the preferences, but still couldn't trigger this issue. I'm clueless at the moment.
image

@jeffshee jeffshee added the bug Something isn't working label Aug 1, 2023
@Tsubajashi
Copy link
Author

i can only reproduce this on ubuntu 23.04 ironically. on Nobara, PopOS, or arch, it "just works". not sure why it doesnt work on 23.04.

@jeffshee
Copy link
Owner

jeffshee commented Aug 1, 2023

I see. Let me try with Ubuntu 23.04 on the VM then.

@Tsubajashi
Copy link
Author

just for info: i cannot reproduce it in a VM. so i guess it has something to do with ubuntu 23.04 + nvidia. works flawlessly in Boxes (Flatpak) and VMWare Workstation Player. it probably has something to do with my setup, although i just dont know what that would be. i dont really do anything different in other distros to get it running with nvidia.

@asmindev
Copy link

i have some problem in ubuntu 23

@SS-KyleSam
Copy link

Same issue here, everything ends up more red.

@jeffshee
Copy link
Owner

jeffshee commented Sep 2, 2023

Hmm, I wonder what will happen if you play the video using the renderer (Hanabi's built-in video player).
Please follow these steps:

  1. In extension pref, enable debug mode.
  2. Disable extension (otherwise step 3 won't work for some reason)
  3. By using the same script used for installation, execute ./run.sh renderer and paste the terminal output here. Please check if the colors are displayed correctly or not. (A fullscreen window will be shown, playing the chosen video)

@LukeScrewdriver
Copy link

Hi, I am on Wayland and i have the same issue.
Here the debug

(gjs:9215): dconf-DEBUG: 19:25:04.179: watch_fast: "/org/gnome/desktop/interface/" (establishing: 0, active: 0)
(gjs:9215): dconf-DEBUG: 19:25:04.179: watch_fast: "/org/gnome/desktop/peripherals/mouse/" (establishing: 0, active: 0)
(gjs:9215): dconf-DEBUG: 19:25:04.179: watch_fast: "/org/gnome/desktop/sound/" (establishing: 0, active: 0)
(gjs:9215): dconf-DEBUG: 19:25:04.179: watch_fast: "/org/gnome/desktop/privacy/" (establishing: 0, active: 0)
(gjs:9215): dconf-DEBUG: 19:25:04.179: watch_fast: "/org/gnome/desktop/wm/preferences/" (establishing: 0, active: 0)
(gjs:9215): dconf-DEBUG: 19:25:04.179: watch_fast: "/org/gnome/settings-daemon/plugins/xsettings/" (establishing: 0, active: 0)
(gjs:9215): dconf-DEBUG: 19:25:04.179: watch_fast: "/org/gnome/desktop/a11y/" (establishing: 0, active: 0)
(gjs:9215): dconf-DEBUG: 19:25:04.179: watch_fast: "/org/gnome/desktop/a11y/interface/" (establishing: 0, active: 0)
(gjs:9215): dconf-DEBUG: 19:25:04.180: watch_established: "/org/gnome/desktop/interface/" (establishing: 1)
(gjs:9215): dconf-DEBUG: 19:25:04.180: watch_established: "/org/gnome/desktop/peripherals/mouse/" (establishing: 1)
(gjs:9215): dconf-DEBUG: 19:25:04.180: watch_established: "/org/gnome/desktop/sound/" (establishing: 1)
(gjs:9215): dconf-DEBUG: 19:25:04.180: watch_established: "/org/gnome/desktop/privacy/" (establishing: 1)
(gjs:9215): dconf-DEBUG: 19:25:04.180: watch_established: "/org/gnome/desktop/wm/preferences/" (establishing: 1)
(gjs:9215): dconf-DEBUG: 19:25:04.180: watch_established: "/org/gnome/settings-daemon/plugins/xsettings/" (establishing: 1)
(gjs:9215): dconf-DEBUG: 19:25:04.180: watch_established: "/org/gnome/desktop/a11y/" (establishing: 1)
(gjs:9215): dconf-DEBUG: 19:25:04.180: watch_established: "/org/gnome/desktop/a11y/interface/" (establishing: 1)
(gjs:9215): Gtk-DEBUG: 19:25:04.183: Connecting to session manager
(gjs:9215): dconf-DEBUG: 19:25:04.209: change_fast
Gjs-Console-Message: 19:25:04.211: using GtkMediaFile for video output
(gjs:9215): Gdk-DEBUG: 19:25:04.300: warning: queue 0x72b854000be0 destroyed while proxies still attached:

(gjs:9215): Gdk-DEBUG: 19:25:04.300:   wl_seat@7 still attached

(gjs:9215): Gdk-DEBUG: 19:25:04.300:   xdg_wm_base@6 still attached

(gjs:9215): Gdk-DEBUG: 19:25:04.300:   wl_subcompositor@5 still attached

(gjs:9215): Gdk-DEBUG: 19:25:04.300:   wl_compositor@4 still attached

(gjs:9215): Gdk-DEBUG: 19:25:04.300:   wl_registry@2 still attached

here the comparison with clapper

immagine

If I can help in any way I am available

@LukeScrewdriver
Copy link

I try to install a virtual machine with the same version of ubuntu and replicate all the installation steps to see if I get the same problem.

@jeffshee
Copy link
Owner

jeffshee commented Apr 4, 2024

Also #102, it seems everyone who has this issue is from Ubuntu...

@LukeScrewdriver
Copy link

On the VM it renders the video correctly.
I followed the installation steps of ubuntu 23.04 (even though I have ubuntu 23.10).
This afternoon I will also try to install the extensions I have on my pc and see if anything breaks.
If even installing the extensions I don't encounter any problems, I might start to think that during an OS update, or after making (maybe not me directly) changes to some configuration file something broke.

@LukeScrewdriver
Copy link

LukeScrewdriver commented Apr 4, 2024

I think I found the solution.
Clapper I installed it by compiling it from source.

  1. I disabled Hanabi
  2. After removing clapper, I reinstalled it following the steps outlined in the Ubuntu 23.04 Installation guide (although the version of ubuntu was not the one I had).
  3. I finished the session
  4. I came back in
  5. I enable Hanabi

To test if the problem was really due to clapper not installed properly i uninstalled it and rerun Hanabi.
The result surprised me, it rendered the video correctly in the first moments then at some point it started to flicker and I could hear the audio twice.

@Rafostar
Copy link
Contributor

Rafostar commented Apr 13, 2024

@LukeScrewdriver

Clapper I installed it by compiling it from source.

Note that from your output:

Gjs-Console-Message: 19:25:04.211: using GtkMediaFile for video output

Which means that you are not (or at least were not) using Clapper with Hanabi when you encountered this issue.

@LukeScrewdriver
Copy link

@Rafostar Thanks.

To me it now says this:

Gjs-Console-Message: 17:44:09.363: using clappersink for video output

I think that is correct

@jeffshee
Copy link
Owner

jeffshee commented Apr 14, 2024

This is just my theory based on the issues so far:

  • GtkMediaFile has some issues with Nvidia GPUs, but has no issue in VM because we are using software rendering (assume no GPU passthrough).
  • Clapper not installed, or the user installed Clapper from the App Center, which defaults to the Snap version instead.
  • Hanabi uses GtkMediaFile because clappersink isn't available (not installed/snap version/not found for some reason), which causes this issue if the user has a Nvidia GPU.

Things you can check for Clapper:

  • Check snap list. If there is clapper in the list, then it's the Snap version.
  • Check gst-inspect-1.0 clapper, the output should look like this:
Plugin Details:
  Name                     clapper
  Description              Clapper elements
  Filename                 /lib/x86_64-linux-gnu/gstreamer-1.0/libgstclapper.so
  Version                  0.5.2
  License                  LGPL
  Source module            clapper
  Binary package           gst-plugin-clapper
  Origin URL               https://github.com/Rafostar/clapper

  clappersink: Clapper video sink

  1 features:
  +-- 1 elements
  • As pointed out above, you can check the currently used implementation from the extension logs. It will show using clappersink for video output if clappersink is used, and vice versa.

@jeffshee
Copy link
Owner

@LukeScrewdriver

I think I found the solution.
Clapper I installed it by compiling it from source.

You managed to resolve the issue by installing Clapper from the source, am I right? Or do you still have the issue?

@jeffshee jeffshee added the renderer Renderer related label Apr 14, 2024
@LukeScrewdriver
Copy link

Sorry, I misunderstood myself.
I would like to point out that I do not have an nvidia video card but intel (intel iris xe).
Clapper I initially installed it by compiling it from source.
By doing it this way I had problems.
I found that it was also present on apt so I removed it and reinstalled it from apt.
Doing it that way solved the problem.

Sorry again for the confusion.

@Rafostar
Copy link
Contributor

So to sum up what @LukeScrewdriver did:
He had Clapper manually complied from source, but it was not actually used by Hanabi then (either sink was not compiled as part of clapper or installed in a place where host GStreamer plugin scanner could not find it). Problem occured. He replaced his installation of Clapper with apt package, Clapper is now found and used by Hanabi and problem is gone.

Clapper not installed, or the user installed Clapper from the App Center, which defaults to the Snap version instead.

This theory seems now very likely. Especially since users who showcased it working correctly in Clapper next to the Hanabi. They might have either Snap or Clapper sink installed/missing in a way that prevents Hanabi to find it.

@Rafostar
Copy link
Contributor

Also, note that what seems to actually happen in this issue is simply wrong video format either assumed or incorrectly treated as something else, e.g: video is RGB but it's displayed as it were BGR or vice versa.

@Jeydin21
Copy link

Has any progress been made on this issue? I'm experiencing it on Ubuntu 23.10, Gnome 45.2

@Jeydin21
Copy link

Has any progress been made on this issue? I'm experiencing it on Ubuntu 23.10, Gnome 45.2

Never mind, I installed Clapper right after I said that and it fixed my issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working renderer Renderer related
Projects
None yet
Development

No branches or pull requests

7 participants