-
Notifications
You must be signed in to change notification settings - Fork 11
/
Copy pathpr.test.js
497 lines (464 loc) · 15.1 KB
/
pr.test.js
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
/* eslint-disable no-undef */
const {
extractPRNumber,
searchPRByCommit,
getReleaseType,
getReleaseNotes,
fetchPR,
} = require('./pr')
test('can extract a PR number from a PR merge commit message', () => {
expect(extractPRNumber('Merge pull request #4 from some/mockBranch')).toEqual('4')
expect(extractPRNumber('Merge pull request #42 from some/mockBranch')).toEqual('42')
})
test('can extract a PR number from a squash merge commit message', () => {
expect(extractPRNumber('My PR squashed (#56)')).toEqual('56')
expect(extractPRNumber('Squash pr (#45)\n\n multiple commit messages appended')).toEqual('45')
})
test('returns null if no PR number is found in a commit message', () => {
expect(extractPRNumber('Merge branch master into some/mockBranch')).toEqual(null)
})
test('searchPRByCommit returns a PR', async () => {
const sha = '123456789'
const config = {
octokit: {
rest: {
search: {
issuesAndPullRequests: async (options) => ({
data: {
total_count: 1,
items: [{ number: 15, id: sha }],
query: options.q,
},
}),
},
},
},
}
expect(searchPRByCommit(sha, config)).resolves.toEqual({ number: 15, id: sha })
})
test('searchPRByCommit Fails to find PR', async () => {
const sha = '123456789'
const config = {
octokit: {
rest: {
search: {
issuesAndPullRequests: async () => ({ data: { total_count: 0 } }),
},
},
},
}
expect(searchPRByCommit(sha, config)).rejects.toThrow(`Failed to find PR by commit SHA ${sha}: No results found querying for the PR`)
})
test('searchPRByCommit throws an error on query', async () => {
const sha = '123456789'
const config = {
octokit: {
rest: {
search: {
issuesAndPullRequests: async () => {
throw new Error('mock error')
},
},
},
},
}
expect(searchPRByCommit(sha, config)).rejects.toThrow(`Failed to find PR by commit SHA ${sha}: mock error`)
})
test('can fetch PR data', async () => {
process.env['GITHUB_REPOSITORY'] = 'mockUser/mockRepo'
const config = {
octokit: {
rest: {
pulls: {
get: async (options) => ({ data: { number: options.pull_number } }),
},
},
},
}
expect(fetchPR(42, config)).resolves.toEqual({ number: 42 })
})
test('throws when fetching PR data fails', async () => {
process.env['GITHUB_REPOSITORY'] = 'mockUser/mockRepo'
const config = {
octokit: {
rest: {
pulls: {
get: async () => {
throw new Error('mock error')
},
},
},
},
}
expect(fetchPR(42, config)).rejects.toThrow('')
})
test('can get release type', () => {
const mockPR = {
labels: [
{ name: 'mock-major-label' },
{ name: 'not-release-related' },
{ name: 'another one' },
],
}
const config = {
releaseLabels: {
'mock-major-label': 'major',
'mock-minor-label': 'minor',
'mock-patch-label': 'patch',
},
noopLabels: {
},
}
const type = getReleaseType(mockPR, config)
expect(type).toEqual('major')
})
test('can get release type with noop labels', () => {
const mockPR = {
labels: [
{ name: 'mock-major-label' },
{ name: 'not-release-related' },
{ name: 'another one' },
],
}
const config = {
releaseLabels: {
'mock-major-label': 'major',
'mock-minor-label': 'minor',
'mock-patch-label': 'patch',
},
noopLabels: {
'documentation change': 'skipped',
},
}
const type = getReleaseType(mockPR, config)
expect(type).toEqual('major')
})
test('can get release type with only noop labels', () => {
const mockPR = {
labels: [
{ name: 'not-release-related' },
{ name: 'documentation change' },
],
}
const config = {
releaseLabels: {
'mock-major-label': 'major',
'mock-minor-label': 'minor',
'mock-patch-label': 'patch',
},
noopLabels: {
'documentation change': 'skip',
},
}
const type = getReleaseType(mockPR, config)
expect(type).toEqual('skip')
})
test('throws if no valid release label is present', () => {
const mockPR = {
labels: [
{ name: 'some-label' },
{ name: 'not-release-related' },
{ name: 'another one' },
],
}
const config = {
releaseLabels: {
'mock-major-label': 'major',
'mock-minor-label': 'minor',
'mock-patch-label': 'patch',
},
noopLabels: {
},
}
expect(() => {
getReleaseType(mockPR, config)
}).toThrow('no release label specified on PR')
})
test('throws if multiple valid release labels are present', () => {
const mockPR = {
labels: [
{ name: 'mock-major-label' },
{ name: 'not-release-related' },
{ name: 'mock-patch-label' },
],
}
const config = {
releaseLabels: {
'mock-major-label': 'major',
'mock-minor-label': 'minor',
'mock-patch-label': 'patch',
},
noopLabels: {
},
}
expect(() => {
getReleaseType(mockPR, config)
}).toThrow('too many release labels specified on PR')
})
test('throws if both a valid release label and a noop label are present', () => {
const mockPR = {
labels: [
{ name: 'mock-major-label' },
{ name: 'not-release-related' },
{ name: 'documentation change' },
],
}
const config = {
releaseLabels: {
'mock-major-label': 'major',
'mock-minor-label': 'minor',
'mock-patch-label': 'patch',
},
noopLabels: {
'documentation change': 'skipped',
},
}
expect(() => {
getReleaseType(mockPR, config)
}).toThrow('too manu labels specified, both release labels and noop labels specified')
})
describe('can parse release notes', () => {
const tests = [
{
name: 'when body is empty',
body: '',
before: '',
after: '',
expected: '',
},
{
name: 'from a single line body',
body: 'a single line body',
before: '',
after: '',
expected: 'a single line body',
},
{
name: 'from a single line body with surrounding whitespace',
body: ' \t a single line body within whitespace \t ',
before: '',
after: '',
expected: 'a single line body within whitespace',
},
{
name: 'from a multline body',
body: 'a multiple\nline body with\n\n newlines',
before: '',
after: '',
expected: 'a multiple\nline body with\n\n newlines',
},
{
name: 'from a multiline body with surrounding whitespace',
body: ' \t\n a multiple\nline body with\n\n newlines within whitespace \t\n ',
before: '',
after: '',
expected: 'a multiple\nline body with\n\n newlines within whitespace',
},
{
name: 'from a multiline body containing single line notes using a prefix',
body: 'before\n\n--begin--\n\na single line\n\n--end---\n\nafter',
before: '--begin--',
after: '',
expected: 'a single line\n\n--end---\n\nafter',
},
{
name: 'from a multiline body containing multiline notes using a prefix',
body: 'before\n\n--begin--\n\nmany\ndifferent lines\n\nhere\n\n--end---\n\nafter',
before: '--begin--',
after: '',
expected: 'many\ndifferent lines\n\nhere\n\n--end---\n\nafter',
},
{
name: 'from a single line body containing single line notes using a prefix and suffix',
body: 'before\n\n--begin--\n\na single line\n\n--end---\n\nafter',
before: '',
after: '--end--',
expected: 'before\n\n--begin--\n\na single line',
},
{
name: '',
body: 'before\n\n--begin--\n\nmany\ndifferent lines\n\nhere\n\n--end---\n\nafter',
before: '',
after: '--end--',
expected: 'before\n\n--begin--\n\nmany\ndifferent lines\n\nhere',
},
{
name: '',
body: 'before\n\n--begin--\n\na single line\n\n--end---\n\nafter',
before: '--begin--',
after: '--end--',
expected: 'a single line',
},
{
name: 'No message if the prefix and suffix are defined but dont appear in the body',
body: 'a single line both',
before: '--begin--',
after: '--end--',
expected: '',
},
{
name: 'No message if the prefix is defined but doesnt appear in the body',
body: 'a single line prefix',
before: '--begin--',
after: '',
expected: '',
},
{
name: 'No message if the suffix is defined but doesnt appear in the body',
body: 'a single line suffix',
before: '',
after: '--after--',
expected: '',
},
{
name: 'with multiline notes from a multiline body using a prefix and suffix',
body: 'before\n\n--begin--\n\nmany\ndifferent lines\n\nhere\n\n--end---\n\nafter',
before: '--begin--',
after: '--end--',
expected: 'many\ndifferent lines\n\nhere',
},
{
name: 'with multiline notes from a multiline body using line-matching patterns',
body: 'before\n\n--begin--\n\nmany\ndifferent lines\n\nhere\n\n--anything--\n\nafter',
before: '^--begin--$',
after: '^--[^-]',
expected: 'many\ndifferent lines\n\nhere',
},
]
tests.forEach((test) => {
const config = {
requireReleaseNotes: false,
}
if (test.before !== undefined && test.before !== '') {
config.releaseNotesPrefixPattern = new RegExp(test.before)
}
if (test.after !== undefined && test.after !== '') {
config.releaseNotesSuffixPattern = new RegExp(test.after)
}
expect(() => {
const notes = getReleaseNotes({ body: test.body }, config)
expect(notes).toBe(test.expected)
}).not.toThrow()
})
})
test('returns empty release notes if not required and not found or empty', async () => {
const bodies = [
'',
'--begin--\n--end--',
]
const config = {
releaseNotesPrefixPattern: /--begin--/,
releaseNotesSuffixPattern: /--end--/,
requireReleaseNotes: false,
}
bodies.forEach((body) => {
const mockPR = { body }
const notes = getReleaseNotes(mockPR, config)
expect(notes).toBe('')
})
})
test('throws if release notes required but not found or empty', async () => {
const tests = [
{
name: 'when body is empty and no prefix or suffix defined',
body: '',
before: '',
after: '',
},
{
name: 'when body is empty and a prefix and suffix defined',
body: '',
before: '--begin--',
after: '--end--',
},
{
name: 'when body is empty and only a prefix defined',
body: '',
before: '--begin--',
after: '',
},
{
name: 'when body is empty and only a suffix defined',
body: '',
before: '',
after: '--end--',
},
{
name: 'when body is not empty and a prefix and suffix defined',
body: 'this is the body',
before: '--begin--',
after: '--end--',
},
{
name: 'when body is not empty and a prefix and suffix defined and used at end',
body: 'this is the body--begin--\n--end--',
before: '--begin--',
after: '--end--',
},
{
name: 'when body is not empty and a prefix and suffix defined and used at beginning',
body: '--begin--\n--end--\nthis is the body',
before: '--begin--',
after: '--end--',
},
{
name: 'when body is not empty and a prefix and suffix defined and used in the middle',
body: 'this is\n--begin--\n--end--\nthe body',
before: '--begin--',
after: '--end--',
},
{
name: 'when body is not empty and a prefix and suffix defined, only begin is used',
body: 'this is the body\n--begin--',
before: '--begin--',
after: '--end--',
},
{
name: 'when body is not empty and a prefix and suffix defined, only end is used',
body: '--end--\nthis is the body',
before: '--begin--',
after: '--end--',
},
{
name: 'when body is not empty and only a prefix defined',
body: 'this is the body',
before: '--begin--',
after: '',
},
{
name: 'when body is not empty and only a prefix defined and used at end',
body: 'this is the body\n--begin--',
before: '--begin--',
after: '',
},
{
name: 'when body is not empty and only a suffix defined',
body: 'this is the body',
before: '',
after: '--end--',
},
{
name: 'when body is not empty and only a suffix defined and used at start',
body: '--end--\nthis is the body',
before: '',
after: '--end--',
},
]
tests.forEach((test) => {
const config = {
requireReleaseNotes: true,
}
if (test.before !== undefined && test.before !== '') {
config.releaseNotesPrefixPattern = new RegExp(test.before)
}
if (test.after !== undefined && test.after !== '') {
config.releaseNotesSuffixPattern = new RegExp(test.after)
}
expect(() => {
getReleaseNotes({ body: test.body }, config)
// Log out the name to make it easier to tell what test failed
// eslint-disable-next-line no-console
console.log(`FAILED: ${test.name}`)
}).toThrow('missing release notes')
})
})