eslint fixes after upgrade

Author: bobnik

.eslintrc.js

@@ -0,0 +1,132 @@
+import js from '@eslint/js'
+import parser from '@typescript-eslint/parser'
+import plugin from '@typescript-eslint/eslint-plugin'
+import react from 'eslint-plugin-react'
+import reactRedux from 'eslint-plugin-react-redux'
+import prettier from 'eslint-plugin-prettier'
+
+export default [
+  js.configs.recommended,
+  {
+    ignores: [
+      'node_modules',
+      'build',
+      'tmp'
+    ],
+    files: ['**/*.ts', '**/*.tsx', '**/*.js', '**/*.jsx'],
+    languageOptions: {
+      parser,
+      parserOptions: {
+        ecmaVersion: 'latest',
+        sourceType: 'module',
+        ecmaFeatures: {
+          jsx: true,
+        },
+      },
+      globals: {
+        jest: true
+      },
+    },
+    plugins: {
+      react,
+      'react-redux': reactRedux,
+      '@typescript-eslint': plugin,
+      prettier,
+    },
+    rules: {
+      // ESLint core
+      'object-shorthand': ['error', 'always'],
+      'no-array-constructor': 'off',
+      'no-redeclare': 'off',
+      'no-use-before-define': 'off',
+      'no-unused-expressions': 'off',
+      'no-unused-vars': 'off',
+      'no-useless-constructor': 'off',
+      semi: ['warn', 'never'],
+
+      // React
+      'react/prop-types': 'off',
+      'react/no-unused-prop-types': 'off',
+
+      // React Redux
+      'react-redux/useSelector-prefer-selectors': 'off',
+      'react-redux/no-unused-prop-types': 'warn',
+      'react-redux/prefer-separate-component-file': 'off',
+
+      // TypeScript overrides
+      ...plugin.configs.recommended.rules,
+      ...prettier.configs.recommended.rules,
+      '@typescript-eslint/consistent-type-assertions': 'warn',
+      '@typescript-eslint/no-array-constructor': 'warn',
+      '@typescript-eslint/no-redeclare': 'warn',
+      '@typescript-eslint/no-use-before-define': [
+        'warn',
+        {
+          functions: false,
+          classes: false,
+          variables: false,
+          typedefs: false,
+        },
+      ],
+      '@typescript-eslint/no-unused-expressions': [
+        'error',
+        {
+          allowShortCircuit: true,
+          allowTernary: true,
+          allowTaggedTemplates: true,
+        },
+      ],
+      '@typescript-eslint/no-unused-vars': [
+        'warn',
+        {
+          args: 'none',
+          ignoreRestSiblings: true,
+        },
+      ],
+      '@typescript-eslint/no-useless-constructor': 'warn',
+
+      // Prettier
+      'prettier/prettier': 'error',
+    },
+    settings: {
+      react: {
+        createClass: 'createReactClass',
+        pragma: 'React',
+        fragment: 'Fragment',
+        version: 'detect',
+        flowVersion: '0.53',
+      },
+      propWrapperFunctions: [
+        'forbidExtraProps',
+        { property: 'freeze', object: 'Object' },
+        { property: 'myFavoriteWrapper' },
+        { property: 'forbidExtraProps', exact: true },
+      ],
+      componentWrapperFunctions: [
+        'observer',
+        { property: 'styled' },
+        { property: 'observer', object: 'Mobx' },
+        { property: 'observer', object: '<pragma>' },
+      ],
+      formComponents: ['CustomForm', { name: 'Form', formAttribute: 'endpoint' }],
+      linkComponents: ['Hyperlink', { name: 'Link', linkAttribute: 'to' }],
+    },
+  },
+  {
+    // Test files
+    files: ['**/*.spec.js', '**/*.spec.ts', '**/*.test.ts', '**/*.spec.tsx', '**/*.test.tsx'],
+    languageOptions: {
+      globals: {
+        describe: true,
+        it: true,
+        test: true,
+        expect: true,
+        beforeEach: true,
+        afterEach: true,
+        beforeAll: true,
+        afterAll: true,
+        jest: true,
+      },
+    },
+  },
+]

eslint.config.mjs

@@ -85,8 +85,8 @@
     "preview": "vite preview",
     "deploy": "gh-pages -d build",
     "test": "jest",
-    "lint": "eslint --fix --ext .js --ignore-path .gitignore src",
-    "lint-ci": "eslint --ext .js --ignore-path .gitignore src"
+    "lint": "eslint --fix --ext .js src",
+    "lint-ci": "eslint --ext .js src"
   },
   "browserslist": [
     ">0.2%",

package.json

@@ -41,13 +41,12 @@ export const edgeKey = (node1, node2) => {
 export default class Graph {
   constructor() {
     this.nodeMap = {}
-    // eslint-disable-next-line no-undef
+
     this.nodeKeys = new Set()
 
     this.adjacencyList = {}
     this.edgeMap = {}
 
-    // eslint-disable-next-line no-undef
     this.edgeKeys = new Set()
     this.clearCachedPaths()
   }

src/common/Graph.js

@@ -1,3 +1,5 @@
+/* global console */
+
 import { compact } from "lodash"
 
 // set to true to enable console logging

src/common/debugging.js

@@ -1,3 +1,5 @@
+/* global window */
+
 import { useState, useEffect } from "react"
 
 const useKeyPress = (targetKey, inputRef) => {

src/common/hooks/useKeyPress.js

@@ -1,3 +1,5 @@
+/* global localStorage, console */
+
 // if you want to save a multiple temporary states, use these keys. The first time
 // you save a new state, change persistSaveKey. Make a change, then change
 // persistLoadKey to the same value. These keys are obsolete now
@@ -12,7 +14,7 @@ export const loadState = (key = persistLoadKey) => {
       return undefined
     }
     return JSON.parse(serializedState)
-  } catch (err) {
+  } catch {
     return undefined
   }
 }

src/common/localStorage.js

@@ -1,7 +1,8 @@
+/* global document, Blob, window, URL */
+
 import { keyBy, compact } from "lodash"
 
 export const difference = (a, b) => {
-  // eslint-disable-next-line no-undef
   return new Set([
     ...[...a].filter((x) => !b.has(x)),
     ...[...b].filter((x) => !a.has(x)),

src/common/util.js

@@ -1,3 +1,5 @@
+/* global document */
+
 import React from "react"
 import Col from "react-bootstrap/Col"
 import Row from "react-bootstrap/Row"

src/components/DropdownOption.js

@@ -1,3 +1,5 @@
+/* global it, document */
+
 import React from "react"
 import { createRoot } from "react-dom/client"
 import App from "./App"