Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a warnning for useNativeDriver #198

Open
shixiaoquan opened this issue Aug 13, 2022 · 0 comments
Open

Fix a warnning for useNativeDriver #198

shixiaoquan opened this issue Aug 13, 2022 · 0 comments

Comments

@shixiaoquan
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-slider/lib/Slider.js b/node_modules/react-native-slider/lib/Slider.js
index c640410..fad8f26 100644
--- a/node_modules/react-native-slider/lib/Slider.js
+++ b/node_modules/react-native-slider/lib/Slider.js
@@ -420,7 +420,7 @@ _this.props.animationConfig,
 {toValue:value});
 
 
-_reactNative.Animated[animationType](_this.state.value,animationConfig).start();},_this.
+_reactNative.Animated[animationType](_this.state.value,{...animationConfig, useNativeDriver: false}).start();},_this.
 
 
 _fireChangeEvent=function(event){
diff --git a/node_modules/react-native-slider/src/Slider.js b/node_modules/react-native-slider/src/Slider.js
index 37deee5..dd48dc5 100644
--- a/node_modules/react-native-slider/src/Slider.js
+++ b/node_modules/react-native-slider/src/Slider.js
@@ -420,7 +420,7 @@ export default class Slider extends PureComponent {
       {toValue : value}
     );
 
-    Animated[animationType](this.state.value, animationConfig).start();
+    Animated[animationType](this.state.value, {...animationConfig, useNativeDriver: true}).start();
   };
 
   _fireChangeEvent = (event) => {

This issue body was partially generated by patch-package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant