Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement - Log Tab Title #71

Closed
barcar opened this issue Apr 6, 2023 · 10 comments
Closed

Enhancement - Log Tab Title #71

barcar opened this issue Apr 6, 2023 · 10 comments

Comments

@barcar
Copy link

barcar commented Apr 6, 2023

Great project. Thank you.

The tabs for log files display the name truncated from the start of the path. Like "/some/folder/..." but, in my opinion, it would be better to show the end of the path like "../log/service.log" (and truncate at the start).

I know that you can hover over the tab to see the full file path but I thought this might be easier.

Alternatively, it would be cool to provide some way to specify the tab title for a particular log in the config file. This might not work so well for wildcards.

And it would be great if you could specify a tab colour for a particular log (or set of logs).

@jdrews
Copy link
Owner

jdrews commented Apr 7, 2023

Thank you!

I think this is working correctly on v2.0.0-beta2. Can you try it there?
image

@jdrews
Copy link
Owner

jdrews commented Apr 7, 2023

Related but not the same as #5

And it would be great if you could specify a tab colour for a particular log (or set of logs).

@barcar
Copy link
Author

barcar commented Apr 7, 2023

Not quite…

File '/mnt/docker/volumes/homebridge_data/_data/homebridge.log' shows up as '...mnt/docker/volumes//'

IMG_0401

@jdrews
Copy link
Owner

jdrews commented Apr 7, 2023

Oh interesting! Thanks for the screenshot and example log file names. I'll try that out here and see if I can recreate to fix it. Thanks!

@jdrews jdrews added this to the 2.0 Release milestone Apr 7, 2023
@jdrews
Copy link
Owner

jdrews commented Apr 12, 2023

I tried using the same path and filename as stated above and I couldn't get to behave as shown in your screenshot.

I'll try running logstation in a docker container to see if it behaves any differently.

What browser were you using? I've tried it on the latest Chrome and Firefox, both of which worked as expected.

@barcar
Copy link
Author

barcar commented Apr 12, 2023 via email

@jdrews
Copy link
Owner

jdrews commented Apr 17, 2023

I was able to reproduce the problem where the logfile gets text-overflow ellipsed on the right side instead of the left. This only seems to happen on Safari. I couldn't get my CSS magic to work on Safari, so instead I'm picking up when it's Safari and only showing the filename and not the path.

image

I made a new beta release. Please try it out and let me know how it goes.
https://github.com/jdrews/logstation/releases/tag/v2.0.0-beta3

@jdrews
Copy link
Owner

jdrews commented Apr 17, 2023

By the way, do you happen to have a M1 or M2 mac? (darwin_arm64)? I made a build for that but I haven't been able to test it since I don't have access to that type of hardware.

@barcar
Copy link
Author

barcar commented Apr 29, 2023

Apologies for the delay. The new version works perfectly in Safari. I'm afraid my Mac is not Apple silicon.

@jdrews
Copy link
Owner

jdrews commented Apr 29, 2023

Great! Thanks for logging this issue and trying out the fix! I'm going to close this issue out.

@jdrews jdrews closed this as completed Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants