Skip to content

Commit b9629bf

Browse files
authored
Merge pull request #5508 from jdi-testing/5360
#5360 fix locators and color reading
2 parents db8ddec + 29df152 commit b9629bf

File tree

2 files changed

+8
-11
lines changed

2 files changed

+8
-11
lines changed

jdi-light-vuetify-tests/src/main/java/io/github/com/pages/ColorPickersPage.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,20 +7,19 @@
77
import com.epam.jdi.light.vuetify.elements.complex.ColorPicker;
88

99
public class ColorPickersPage extends VuetifyPage {
10-
// @todo #5298 Locators should use .v-color-picker class
11-
@UI("#CanvasColorPicker > div:first-child")
10+
@UI("#CanvasColorPicker .v-color-picker")
1211
public static ColorPicker noCanvasColorPicker;
1312

1413
@UI("#CanvasColorPicker > div:nth-child(2)")
1514
public static ColorPicker fullCanvasColorPicker;
1615

17-
@UI("#ElevationColorPicker > div:first-child")
16+
@UI("#ElevationColorPicker .v-color-picker")
1817
public static ColorPicker flatColorPicker;
1918

2019
@UI("#ElevationColorPicker > div:nth-child(2)")
2120
public static ColorPicker elevationColorPicker;
2221

23-
@UI("#InputsColorPicker > div:nth-child(1)")
22+
@UI("#InputsColorPicker .v-color-picker")
2423
public static ColorPicker noInputsColorPicker;
2524

2625
@UI("#InputsColorPicker > div:nth-child(3)")
@@ -47,10 +46,10 @@ public class ColorPickersPage extends VuetifyPage {
4746
@UI("#ModelColorPicker div.col-md-4 button:nth-of-type(5)")
4847
public static VuetifyButton hsvaModelButton;
4948

50-
@UI("#ModelColorPicker div.d-flex")
49+
@UI("#ModelColorPicker .v-color-picker")
5150
public static ColorPicker modelColorPicker;
5251

53-
@UI("#SwatchesColorPicker > div:first-child")
52+
@UI("#SwatchesColorPicker .v-color-picker")
5453
public static ColorPicker mediumSwatchesColorPicker;
5554

5655
@UI("#SwatchesColorPicker > div:nth-child(2)")

jdi-light-vuetify/src/main/java/com/epam/jdi/light/vuetify/elements/complex/ColorPicker.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
// @todo #5310 Simplify and refactor this element, too many hardcoded values. Check if all colors are possible to get
1919
public class ColorPicker extends UIBaseElement<ColorPickerAssert> implements HasElevation, HasTheme {
2020

21-
public static final String STYLE = "style";
2221
public static final String DIV = "div";
2322
public static final String RGBA = "RGBA";
2423
public static final String RGB = "RGB";
@@ -108,6 +107,7 @@ public void setColor(String value) {
108107
String green = String.valueOf(color.getGreen());
109108
String blue = String.valueOf(color.getBlue());
110109
double doubleAlpha = color.getAlpha() / 255.0D;
110+
// @todo #5360 View of alpha channel depends on regional settings
111111
String alpha = String.format("%.2f", doubleAlpha).replace(",", ".");
112112
inputRH().setText(red);
113113
inputGS().setText(green);
@@ -127,9 +127,7 @@ public String getInputModel() {
127127

128128
@JDIAction("Get color from '{name}'")
129129
public Color getColor(UIElement element) {
130-
String styleColor = getElementStyle(element);
131-
String stringColor = styleColor.substring(12, styleColor.length() - 1);
132-
return Color.fromString(stringColor);
130+
return Color.fromString(element.css("background-color"));
133131
}
134132

135133
@JDIAction("Get colors from '{name}' swatches")
@@ -146,7 +144,7 @@ public ArrayList<Color> getColorsFromSwatches() {
146144
}
147145

148146
public String getElementStyle(UIElement element) {
149-
return element.attr(STYLE);
147+
return element.attr("style");
150148
}
151149

152150
}

0 commit comments

Comments
 (0)