Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a pure "DataSource" proxy instead of "ProxyDataSource" #51

Open
ttddyy opened this issue Nov 2, 2024 · 0 comments
Open

Use a pure "DataSource" proxy instead of "ProxyDataSource" #51

ttddyy opened this issue Nov 2, 2024 · 0 comments
Assignees
@ttddyy
Labels
enhancement New feature or request
Milestone
v1.1.0

Comments

@ttddyy
Copy link
Member

ttddyy commented Nov 2, 2024

Currently, instrumentation converts DataSource to ProxyDataSource.
ProxyDataSourceBuilder#buildProxy() method is added to datasource-proxy-1.10 and it generates a pure proxy of the DataSource object rather than a ProxyDataSource instance. Using this pure proxy will help avoid issues such as #46.

Additionally, we should add a property to allow users to retain the old behavior with ProxyDataSource, if needed.
@ttddyy ttddyy added the enhancement New feature or request label Nov 2, 2024
@ttddyy ttddyy added this to the v1.1.0 milestone Nov 2, 2024
@ttddyy ttddyy self-assigned this Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ttddyy ttddyy

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.1.0
Development

No branches or pull requests
1 participant
@ttddyy