Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async echo doesn't work with flush: false #1000

Open
jcubic opened this issue Dec 21, 2024 · 1 comment
Open

async echo doesn't work with flush: false #1000

jcubic opened this issue Dec 21, 2024 · 1 comment
Labels
Bug resolved if issue is resolved, it will be open until merge with master

Comments

@jcubic
Copy link
Owner

jcubic commented Dec 21, 2024

Issue summary

When you echo async function without flush, the output is not flushed at all

Expected behavior

flush should always output the content you echo

Steps to reproduce

Write this code:

term.echo(async () => 'Hello', { newline: false, flush: false });
term.echo(async () => ', world!', { flush: false });
term.flush();

Browser and OS

N/A

Additional notes

New devel method terminal::view_ready() fix the issue. It seems that terminal::view_ready() needs to be changed to terminal::output_ready().

@jcubic jcubic added the Bug label Dec 21, 2024
@jcubic
Copy link
Owner Author

jcubic commented Dec 25, 2024

Also the types needs to be updated

jcubic added a commit that referenced this issue Jan 14, 2025
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Development

No branches or pull requests

1 participant