Mac: Menu items does not trigger the expected action

[tbdalgaard]

This was discovered on RWP back in December 2024 by another member of the group, John.

I could not get a clean discussion link, so I have tried to make a short version from the thread here Note that the OSARA build versions are quite out of date, but the findings are still relevant in the latest development snapshots:

When going to the extensions and the OSARA submenu the follow menu items does not trigger the action they are bound to:

• Online documentation
• Check for update
• Configure REAPER for optimal screen reader accessibility

Expected: When activating any of the menu items above the action should be triggered. Like online documentation, will show up in a browser window etc.
Observed: Menu closes and focus is back to the Reaper window.

This was first located around December 6th 2024.
I ran an older version of OSARA in a new, portable Reaper.
Version: 2024.10.18.1617,2b17b87b
Here all the menu items work as expected.
I then updated that version of OSARA to:
Version: 2024.12.18.1644,aae6bab6

After doing so the menu items stopped working again.

The actions work though, if I run them via the action list, so the code itself seems to work correctly.

[pitermach]

I can reproduce this here also, using the test snapshot that was created for the virtual midi keyboard improvements. The items for about and OSARA configuration work, while check for updates, documentation and configure for optimal accessibility only work if triggered from the actions dialog.

…

On 23 Mar 2025, at 07:17, Thomas Byskov Dalgaard ***@***.***> wrote: tbdalgaard created an issue (jcsteh/osara#1218) This was discovered on RWP back in December 2024 by another member of the group, John. I could not get a clean discussion link, so I have tried to make a short version from the thread here Note that the OSARA build versions are quite out of date, but the findings are still relevant in the latest development snapshots: When going to the extensions and the OSARA submenu the follow menu items does not trigger the action they are bound to: Online documentation Check for update Configure REAPER for optimal screen reader accessibility Expected: When activating any of the menu items above the action should be triggered. Like online documentation, will show up in a browser window etc. Observed: Menu closes and focus is back to the Reaper window. This was first located around December 6th 2024. I ran an older version of OSARA in a new, portable Reaper. Version: 2024.10.18.1617,2b17b87b Here all the menu items work as expected. I then updated that version of OSARA to: Version: 2024.12.18.1644,aae6bab6 After doing so the menu items stopped working again. The actions work though, if I run them via the action list, so the code itself seems to work correctly. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread. <#1218> <https://github.com/notifications/unsubscribe-auth/ABAABTJWCU4CCHNZL37ESEL2VZGYVAVCNFSM6AAAAABZSWAAKOVHI2DSMVQWIX3LMV43ASLTON2WKOZSHE2DAOJWGM2TCMI> tbdalgaard created an issue (jcsteh/osara#1218) <#1218> This was discovered on RWP back in December 2024 by another member of the group, John. I could not get a clean discussion link, so I have tried to make a short version from the thread here Note that the OSARA build versions are quite out of date, but the findings are still relevant in the latest development snapshots: When going to the extensions and the OSARA submenu the follow menu items does not trigger the action they are bound to: Online documentation Check for update Configure REAPER for optimal screen reader accessibility Expected: When activating any of the menu items above the action should be triggered. Like online documentation, will show up in a browser window etc. Observed: Menu closes and focus is back to the Reaper window. This was first located around December 6th 2024. I ran an older version of OSARA in a new, portable Reaper. Version: 2024.10.18.1617,2b17b87b Here all the menu items work as expected. I then updated that version of OSARA to: Version: 2024.12.18.1644,aae6bab6 After doing so the menu items stopped working again. The actions work though, if I run them via the action list, so the code itself seems to work correctly. — Reply to this email directly, view it on GitHub <#1218>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABAABTJWCU4CCHNZL37ESEL2VZGYVAVCNFSM6AAAAABZSWAAKOVHI2DSMVQWIX3LMV43ASLTON2WKOZSHE2DAOJWGM2TCMI>. You are receiving this because you are subscribed to this thread.

[jcsteh]

Thanks for reporting this and especially for providing the exact version numbers for the before and after builds you tried. That is enormously helpful in narrowing down a regression and saves a lot of time.

Looking at that commit range, I suspect this was caused by #1180 (Support interception of commands provided by extensions such as SWS). I don't fully understand why it breaks Mac but not Windows. However, in retrospect, I can see why it might break things in some cases. That change caused us to register OSARA commands later than we did previously. If the menu hook runs before our command registration code runs, that will break because our commands don't exist yet and so we can't get the correct ids to associate with the menu commands.

I need to think about how to fix this without breaking the thing I was originally trying to fix.