Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flawed logic in ingress controller pod discovery #1047

Closed
avmnu-sng opened this issue Nov 6, 2023 · 4 comments
Closed

Flawed logic in ingress controller pod discovery #1047

avmnu-sng opened this issue Nov 6, 2023 · 4 comments
Labels
kind/bug

Comments

@avmnu-sng
Copy link

I feel kubernetes/ingress-nginx#7047 applies to HAProxy ingress. Can you take a look?

As pointed out in the kubernetes/ingress-nginx#7047 (comment) comment, we also use all the labels https://github.com/jcmoraisjr/haproxy-ingress/blob/master/pkg/common/ingress/controller/status.go#L262-L271.
@jcmoraisjr
Copy link
Owner

Hi, thanks for pointing this issue to our attention! Just created #1116 which I hope fixes this on our codebase.

@avmnu-sng
Copy link
Author

@jcmoraisjr Thanks. It will fix the issue.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024

This issue got stale and will be closed in 7 days.

@jcmoraisjr
Copy link
Owner

Merged and will be available in the next v0.12, v0.13, v0.14 and v0.15 versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jcmoraisjr @avmnu-sng