Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support authentication #9

Open
7 tasks
jchesterpivotal opened this issue Aug 26, 2018 · 2 comments
Open
7 tasks

Support authentication #9

jchesterpivotal opened this issue Aug 26, 2018 · 2 comments
Assignees
Labels
blocked help wanted Extra attention is needed size/L
Milestone

Comments

@jchesterpivotal
Copy link
Owner

jchesterpivotal commented Aug 26, 2018

Description

Currently, the resource only works for public jobs in public pipelines.

This is rather limiting.

Something like:

- name: build
  type: concourse-build
  source:
    concourse_url: https://concourse.example.com
    authentication:
      # ???

Open questions

  • How does this actually work? Authentication has lots of knobs and dials. Presumably I would need to implement some logic per scheme -- one for github, one for CF auth etc.
  • Limit to 4.x and above? Authentication changed radically in 4.0, which is why there's a 4.0.
  • How would tokens work? Do we log in every time?
  • What happens when authentication fails?
  • What information is recorded about auth? Do I add it to version metadata? Print it to stderr? Create more K-V files? All of these?

Todos

Assuming I focus on github only and split out other auth options into standalone issues.

  • check
    • cmd/check
    • pkg/check
  • in
    • cmd/in
    • pkg/in
  • Readme
@jchesterpivotal jchesterpivotal added the help wanted Extra attention is needed label Aug 26, 2018
@jchesterpivotal jchesterpivotal modified the milestones: 1.0.0, v1.0.0 Aug 26, 2018
@jchesterpivotal jchesterpivotal self-assigned this Sep 1, 2018
@jchesterpivotal
Copy link
Owner Author

A note on supported versions. Given my intention in #28 to rely entirely on upstream go module definitions, it won't be possible to support this feature for Concourse below (approximately) 4.2.1. Given that it's just me working on this, I am totally comfortable with that policy.

@jchesterpivotal
Copy link
Owner Author

Marking blocked on #28.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked help wanted Extra attention is needed size/L
Projects
None yet
Development

No branches or pull requests

1 participant