Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shellcheck issues #4

Closed
ghost opened this issue Dec 23, 2016 · 6 comments
Closed

Shellcheck issues #4

ghost opened this issue Dec 23, 2016 · 6 comments

Comments

@ghost
Copy link

ghost commented Dec 23, 2016

Shellcheck output: http://ix.io/1O7F

Git patch: http://ix.io/107J
@ghost
Copy link
Author

ghost commented Dec 23, 2016

Since github edit buttons don't seem to work for me, the real link for the patch is: http://ix.io/1O7J

@jc00ke
Copy link
Owner

jc00ke commented Dec 23, 2016

Shellcheck! Thanks, though that patch doesn't look right.

Could you open a PR instead?

@jc00ke
Copy link
Owner

jc00ke commented Dec 23, 2016

Ah, just saw your new comment, that looks right. I'll take a look shortly.

@ghost
Copy link
Author

ghost commented Dec 23, 2016

I cba to clone the repo. I really hate the way github works.

@jc00ke
Copy link
Owner

jc00ke commented Dec 25, 2016

The patch doesn't cleanly check out. Is your patch based on the latest on master? I'd like for it to cleanly apply and to sign off as well.

@ghost
Copy link
Author

ghost commented Dec 25, 2016

The version I cloned and subsequently edited was 4040159

@jc00ke jc00ke mentioned this issue Dec 27, 2016
Merged
@jc00ke jc00ke closed this as completed Feb 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jc00ke