Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model KVStore initial migration not in package when installing via pip #458

Open
jlariza opened this issue Jul 15, 2016 · 8 comments
Open

Comments

@jlariza
Copy link

jlariza commented Jul 15, 2016

I installed the package via pip and I was getting a programming error. I had to create the KVStore inital migration manually to make it work because apparently it was not there.

python manage.py makemigrations thumbnail

Migrations for 'thumbnail':
0001_initial.py:
- Create model KVStore

It should be included in the package to avoid problems. thank you

@kevin-brown
Copy link

It already exists.

https://github.com/mariocesar/sorl-thumbnail/blob/c7d9e9d6d55d89f0a7aaa867d087d713cd76937c/sorl/thumbnail/migrations/0001_initial.py

It's just not in any releases on PyPI, which is the real issue.

@wiesson
Copy link

wiesson commented Oct 24, 2016

Any updates to this issue?

@dmwyatt
Copy link

dmwyatt commented Jan 2, 2017

@mariocesar This really needs addressed! No one can use this library without googling around and figuring out that it's not working because migrations aren't included in the package they installed.

@mariocesar
Copy link
Collaborator

@dmwyatt You are right, need wrap a plan to maintain some compatibility and release a new version in the process.

If you want to help, solving tests and maintaining compatibility while doing the upgrade will fix all we need to release.

@pembeci
Copy link

pembeci commented Apr 26, 2017

Installed with pip, followed the documentation, decided to use the default settings and bumped into this. Easy to solve of course but for a beginner user this still seems to be an issue.

@mariocesar
Copy link
Collaborator

Main issue is that the stable version is really outdated, and the work on the next released is stalled. If someone wants to give a hand on the next release is welcome. There is really not much work, update some tests, rename somethings, and other minor things

@pembeci
Copy link

pembeci commented Apr 26, 2017

@mariocesar, thanks for the update. Is there a todo list for the new release somewhere so newcomers can try to help?

@WhyNotHugo
Copy link
Member

Can we at least have a release 12.3.1 branched off with 12.3, but with just the migration included? Currently, bootstrapping most projects has hacks in place to generate that migration (or curl it from github), and it's really hacky.

Also, like @pembeci said, a list of things that need work for the next release (maybe just tag the GH issues) would be great. I'm sure I can make the time to work on them at some point, but most importantly, I'm sure other are.

katur added a commit to katur/forthebirds that referenced this issue Jan 18, 2022
Note: thumbnail.0001_initial migration was not in my django_migrataion
table, so after this upgrade I was prompted to apply the migration, which
then errored out because the thumbnail_kvstore table already exists.

Probably related to the issue here:
jazzband/sorl-thumbnail#458

To fix, I just manually added a row to django_migrations to indicate
that this migration was already applied.
katur added a commit to katur/forthebirds that referenced this issue Jan 21, 2022
* Upgrade to Django==2.0.13

* Add missing ON DELETE CASCADE to old migrations

* Upgrade to Django==2.2.17

Hoping to solve string type problem, in case related to python 3.9

* Replace auth_views.login/logout with auth_views.LoginView/LogoutView

* %s/MIDDLEWARE_CLASSES/MIDDLEWARE

* Update to default Django 2.2 middleware

* Resolve TypeError by removing byte qualifier in M2M fields in migrations

Was getting this error when trying to run migrations, the stack trace
pointing at M2M fields:
TypeError: attribute name must be string, not 'bytes'

* Drop parens from user.is_authenticated

* Change Login/LogoutView to Login/LogoutView.as_view()

* Nest login.html in registration dir

* Upgrade to 2.2.26

* Upgrade to sorl-thumbnail==12.4.1

Note: thumbnail.0001_initial migration was not in my django_migrataion
table, so after this upgrade I was prompted to apply the migration, which
then errored out because the thumbnail_kvstore table already exists.

Probably related to the issue here:
jazzband/sorl-thumbnail#458

To fix, I just manually added a row to django_migrations to indicate
that this migration was already applied.

* Upgrade to sorl-thumbnail==12.5.0

This fixes the bug on the UploadedImage admin (due to sorl thumbnail
widget compatibility)

* Upgrade all the way to sorl-thumbnail==12.7.0

* Upgrade to django-taggit==2.0.0

* Restore cors middleware (and upgrade package)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants