Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token verification is passing after token rotation #46

Open
regzon opened this issue Oct 18, 2018 · 4 comments
Open

Token verification is passing after token rotation #46

regzon opened this issue Oct 18, 2018 · 4 comments
Labels

Comments

@regzon
Copy link

regzon commented Oct 18, 2018

After token refreshing (with refresh token rotation enabled) old refresh token is still passing validation.

Blacklist app is in INSTALLED APPS

Settings:
SIMPLE_JWT = { 'ROTATE_REFRESH_TOKENS': True, 'BLACKLIST_AFTER_ROTATION': True, }

@sshishov
Copy link

sshishov commented Feb 16, 2019

Please retest this issue as for me it is not passed.
Rotation only happens when you call refresh API with provided refresh token.
I noticed that old RefreshToken is not blacklisted if new pair is generated using ordinary login what is also the omission in my understanding

@adriangzz
Copy link

I'm facing the same issue. When I use the verify API provided I still get a 200 OK status with the previous, now blacklisted refresh token.

@saadmk11
Copy link
Contributor

You need to add 'rest_framework_simplejwt.token_blacklist', app in the INSTALLED_APPS in the django settings file to use this feature.

https://django-rest-framework-simplejwt.readthedocs.io/en/latest/blacklist_app.html?highlight=blacklist#blacklist-app

@Andrew-Chen-Wang
Copy link
Member

I believe this issue is not simply just the token blacklist app itself, but also the fact that the functionality is not actually implemented. I've seen a lot of issues lately regarding the blacklist app, and it seems like the functionality may just be broken.

Once my midterms are over, I'll take a look at this again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants