Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TokenObtainPairView raise BadRequest instead of Unauthorized #43

Closed
ityshchenko opened this issue Sep 25, 2018 · 5 comments
Closed

TokenObtainPairView raise BadRequest instead of Unauthorized #43

ityshchenko opened this issue Sep 25, 2018 · 5 comments

Comments

@ityshchenko
Copy link

Steps to reproduce:

  1. Create user
  2. Try sign in with a wrong password.
@davesque
Copy link
Member

Yeah, I think you're right that 401 is more appropriate in that case. I just made a PR for this and you're free to inspect. I'll merge it in a day or so.

Actually, now that we're raising more non-validation errors inside of serializers, it's making the point that @sergiowalls was trying to make in #24 seem more valid.

@wdifruscio
Copy link

Hi, is this fixed yet, or any plans to? I would like to have this!

@davesque
Copy link
Member

@wdifruscio Thanks for reminding me about this :). I just rebased that PR and will merge it. I'll probably cut a minor version release soon with that change included.

@davesque
Copy link
Member

@wdifruscio Just cut v4.2 with this fix included.

@wdifruscio
Copy link

@davesque Thanks so much!!! Amazing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants