-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TokenObtainPairView raise BadRequest instead of Unauthorized #43
Comments
Yeah, I think you're right that 401 is more appropriate in that case. I just made a PR for this and you're free to inspect. I'll merge it in a day or so. Actually, now that we're raising more non-validation errors inside of serializers, it's making the point that @sergiowalls was trying to make in #24 seem more valid. |
Hi, is this fixed yet, or any plans to? I would like to have this! |
@wdifruscio Thanks for reminding me about this :). I just rebased that PR and will merge it. I'll probably cut a minor version release soon with that change included. |
@wdifruscio Just cut v4.2 with this fix included. |
@davesque Thanks so much!!! Amazing |
Steps to reproduce:
The text was updated successfully, but these errors were encountered: