Enable configurable root URL paths #164
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #164 +/- ##
=======================================
Coverage 97.67% 97.67%
=======================================
Files 17 17
Lines 689 689
Branches 56 56
=======================================
Hits 673 673
Misses 10 10
Partials 6 6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Needs rebase |
blag
force-pushed
the
better-url-config
branch
from
39569b1 to
7538ae0
Compare
WhyNotHugo
reviewed
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow this app's URLConf to be parented in more places than just
/account/.Description
This PR removes the
/account/prefix from this app's URLConf, allowing developers to choose for themselves what URL prefixes they would like.To ensure backwards compatibility, I adjusted the root URLConfs in the
testsproject and theexampleproject to still use the/account/prefix. Furthermore, I also adjusted the documentation to instruct users to do the same:Advanced users should hopefully understand that they can adjust that prefix to whatever they'd like, and beginner users will simply mirror the documentation and continue with the previous behavior.
Motivation and Context
The previously behavior isn't necessarily congruous with django-allauth, which uses
/accounts/, and other users might want different prefixes altogether.Closes #43 and #47.
How Has This Been Tested?
I updated the URLConf in the
testsproject and relied on GHA tests.Screenshots (if appropriate):
Types of changes
Checklist:
Assuming that tests for Python 3.7+Django 3.2 pass (currently running), test results for this branch have not changed from test results for
master.