Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integrate django-u2f #86

Open
sserrano44 opened this issue Mar 5, 2015 · 5 comments · May be fixed by #215
Open

integrate django-u2f #86

sserrano44 opened this issue Mar 5, 2015 · 5 comments · May be fixed by #215
Labels
enhancement question

Comments

@sserrano44
Copy link

I would be great to integrate: https://github.com/gavinwahl/django-u2f

What would it take?
@Bouke
Copy link
Collaborator

Bouke commented Mar 5, 2015

I've been thinking of a modular approach to django-two-factor-auth. Currently there's support for phone numbers (pluggable provider, Twillio by default), apps (QR code) and yubikeys. However there are more providers of token generators, and I don't intent on implementing them all. However a generic package to support them all would be nice to have. u2f could then be provided as an add-on token module.

If you want to support u2f in the short term, have a look at how yubikeys are currently implemented. I would suggest taking the same approach for u2f.

@moreati
Copy link
Contributor

moreati commented Jul 11, 2015

I'm working on this. The (INSECURE, DO NOT USE it as is) proof of concept is moreati@a44ac23

@moreati moreati mentioned this issue Jul 11, 2015
Closed
@khanzf
Copy link

khanzf commented Mar 29, 2016

I plan on contributing to this. Just did my own implementation and it worked!
Until then, why not rename internal functions from "Yubikey" to U2F? YubiKey is my favorite provider of U2F tokens, but U2F is a standard.

@vereena42 vereena42 linked a pull request Jun 11, 2017 that will close this issue
Open
@Bouke Bouke mentioned this issue Aug 30, 2017
Closed
goetzk added a commit to goetzk/django-two-factor-auth that referenced this issue Nov 4, 2017
@goetzk
Start of modularising branch
f544ebc 
This relates to django-two-factor-auth jazzband#233, jazzband#215 (and by extension jazzband#86 and
others)

In a broken state, I'll re visit another time (this was really just to try some
ideas)
@roffel
Copy link

roffel commented Nov 10, 2017

Is there any progress made in the last year+? Will this feature be integrated?

@claudep
Copy link
Contributor

claudep commented Feb 24, 2023

Is this still wanted now that we have webauthn as a plugin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add U2F devices feature vereena42/django-two-factor-auth
6 participants
@sserrano44 @claudep @moreati @Bouke @roffel @khanzf