Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to override get_available_phone_methods() ? #233

Closed
goetzk opened this issue Nov 2, 2017 · 2 comments
Closed

How to override get_available_phone_methods() ? #233

goetzk opened this issue Nov 2, 2017 · 2 comments
Labels

Comments

@goetzk
Copy link

goetzk commented Nov 2, 2017

Hi,
I'm trying to add another (couple of) authentication sources and so I need to change get_available_phone_methods() allow items other than sms/phone/yubikey. I have already made django_otp Device model classes for my new sources added devices for each, testing in a python shell and minimal django they work and I'm now trying to figure out the upper layers - in this case, trying out two_factor.

If changing override get_available_phone_methods() turns out to be doable I'll investigate what changes are required to the UI code in order to expose the new devices for users to register their own.

thanks,
kk

@Bouke
Copy link
Collaborator

Bouke commented Nov 3, 2017

Hi there, I've been playing with the idea of introducing some sort of pluggable architecture, see also my comments in this bug report: #215.

@goetzk
Copy link
Author

goetzk commented Nov 3, 2017 via email

goetzk added a commit to goetzk/django-two-factor-auth that referenced this issue Nov 4, 2017
This relates to django-two-factor-auth jazzband#233, jazzband#215 (and by extension jazzband#86 and
others)

In a broken state, I'll re visit another time (this was really just to try some
ideas)
@Bouke Bouke closed this as completed Nov 12, 2017
@Bouke Bouke added the question label Nov 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants