Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optionally use select_related to pull related fields for old #415

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dgravitate
Copy link

Add the ability to use select_related to pull related fields when getting the old instance to compare against. This should eliminate some unnecessary queries and boost performance, particularly when dealing with lots of related fields.

@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Merging #415 (b8d6dab) into master (a00d2c2) will decrease coverage by 0.77%.
The diff coverage is 53.84%.

@@            Coverage Diff             @@
##           master     #415      +/-   ##
==========================================
- Coverage   91.79%   91.01%   -0.78%     
==========================================
  Files          23       23              
  Lines         646      657      +11     
==========================================
+ Hits          593      598       +5     
- Misses         53       59       +6     
Impacted Files Coverage Δ
auditlog/receivers.py 86.36% <50.00%> (-13.64%) ⬇️
auditlog/conf.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hramezani
Copy link
Member

Thanks @dgravitate for the patch 👍

I haven't looked in detail at the patch. but you need:

@dgravitate dgravitate marked this pull request as draft August 17, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants