Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip backticks not needed by commands #9

Open
jayvdb opened this issue Jul 17, 2019 · 1 comment
Open

Skip backticks not needed by commands #9

jayvdb opened this issue Jul 17, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@jayvdb
Copy link
Owner

jayvdb commented Jul 17, 2019

If a backtick isnt used by any commands for a testenv, it doesnt need to be evaluated, unless the purpose was to set the envvar for one of the command to read.

There could be a flag which separates envvars needed within the tox.ini vs envvars needed to be passed to the commands.

Potentially filter the list to be passed to the commands could be a separate tox plugin, which this plugin could detect and then it knows which envvars it can eliminate.

@jayvdb jayvdb added the enhancement New feature or request label Jul 17, 2019
@jayvdb
Copy link
Owner Author

jayvdb commented Jul 17, 2019

A way to add support for defining which envvars are needed inside commands is for setenv _FOO= to be considered private to tox , not needed by the commands.

There are very few _ envvars that are used by commands, and they would not be supported by backticks. A non-breaking change later can replace that with a better mechanism if required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant