🐞 Intercalary Leap Days not advancing moon cycles

[SerenityFlux]

Check for existing bug reports before submitting.

• I searched for existing Bug Reports and found no similar reports.

Expected Behavior

I would expect that moons count each day that occurs in a year when advancing their lunar cycle.

Current behaviour

However, I noticed drift in a moon cycle that should align on the first day of each year. Upon testing, it seems that if I set a leap day to not be intercalary, the moon cycle adjusts by 1 on the start of the second year, bringing it in line with my expectations. Unfortunately, this means that if I use intercalary leap days, the moon cycles will experience considerable drift over the years.

Reproduction

1. Create a calendar with no moons and no leap days.
2. Ensure that at least one day of the year is a leap day which occurs every year, but is not intercalary.
3. Create a moon. Ensure its cycle will match with the total number of days in the year, such that it will be in the same phase on the first day of each year. For my testing, I used a 326 day year and a 32.6 day cycle.
4. Confirm that the moon phase matches each year.
5. Now change the one leap day to be intercalary.
6. Check the moon phase on the first day of the second year. It should have drifted by one day.

Note: Depending on the specific number of days per year/moon cycle, you may need more intercalary leap days to make the shift apparent

Which Operating Systems are you using?

• Android
• iPhone/iPad
• Linux
• macOS
• Windows

Obsidian Version Check

1.12.4 and 1.12.4

Plugin Version

2.1.0

Confirmation

• I have disabled all other plugins and the issue still persists.

Possible solution

No response