Skip to content

Multiple following intercalary days do not render properly #228

@AtomicBackspace

Description

@AtomicBackspace

Check for existing bug reports before submitting.

  • I searched for existing Bug Reports and found no similar reports.

Expected Behavior

When I add multiple ìntercalary` leap days after one another, they should both render with the name in the calendar view.

Current behaviour

The first leap day renders fine, the second one renders as another row in the calendar with a number instead of showing the name.,

Reproduction

I am trying to import two calendars:

  • One I created https://fantasy-calendar.com/ manually to proof of concept multiple intercalary days
  • One I created myself with my full calendar defined in it

The exported calendar from fantasy-calendar.com does not import properly:

{
    "name": "Double Intercalary",
    "static_data": {
        "year_data": {
            "first_day": 1,
            "overflow": false,
            "global_week": [
                "Monday",
                "Tuesday",
                "Wednesday",
                "Thursday",
                "Friday",
                "Saturday",
                "Sunday"
            ],
            "timespans": [
                {
                    "name": "January",
                    "type": "month",
                    "length": 28,
                    "interval": 1,
                    "offset": 0
                },
                {
                    "name": "February",
                    "type": "month",
                    "length": 28,
                    "interval": 1,
                    "offset": 0
                }
            ],
            "leap_days": [
                {
                    "name": "Good-day",
                    "intercalary": true,
                    "timespan": 0,
                    "adds_week_day": false,
                    "day": 28,
                    "week_day": "",
                    "interval": "1",
                    "offset": 0,
                    "not_numbered": false,
                    "show_text": true
                },
                {
                    "name": "Best-day",
                    "intercalary": true,
                    "timespan": 0,
                    "adds_week_day": false,
                    "day": 28,
                    "week_day": "",
                    "interval": "1",
                    "offset": 0,
                    "not_numbered": false,
                    "show_text": true
                }
            ]
        },
        "moons": [],
        "clock": {
            "enabled": false,
            "render": false,
            "hours": 24,
            "minutes": 60,
            "offset": 0,
            "crowding": 0
        },
        "seasons": {
            "data": [],
            "locations": [],
            "global_settings": {
                "season_offset": 0,
                "weather_offset": 0,
                "seed": 1234567,
                "temp_sys": "metric",
                "wind_sys": "metric",
                "cinematic": false,
                "enable_weather": false,
                "periodic_seasons": true,
                "color_enabled": false
            }
        },
        "eras": [],
        "settings": {
            "layout": "grid",
            "comments": "none",
            "show_current_month": false,
            "private": false,
            "allow_view": true,
            "only_backwards": true,
            "only_reveal_today": false,
            "hide_moons": false,
            "hide_clock": false,
            "hide_events": false,
            "hide_eras": false,
            "hide_all_weather": false,
            "hide_future_weather": false,
            "add_month_number": false,
            "add_year_day_number": false,
            "default_category": -1
        },
        "cycles": {
            "format": "",
            "data": []
        }
    },
    "dynamic_data": {
        "year": 1,
        "timespan": 0,
        "day": 1,
        "epoch": 0,
        "custom_location": false,
        "location": null
    },
    "events": [],
    "categories": []
}

And the one I created myself, that successfully imports at least:

{
  "name": "Test Calendar",
  "description": "",
  "path": [],
  "supportInlineEvents": false,
  "inlineEventTag": "inline-events",
  "showIntercalarySeparately": true,
  "static": {
    "displayDayNumber": false,
    "firstWeekDay": 0,
    "incrementDay": false,
    "displayMoons": true,
    "overflow": true,
    "padDays": 2,
    "padMonths": 2,
    "weekdays": [
      {
        "type": "day",
        "name": "Monday",
        "id": "ID_weekday_0000"
      },
      {
        "type": "day",
        "name": "Tuesday",
        "id": "ID_weekday_0001"
      },
      {
        "type": "day",
        "name": "Wednesday",
        "id": "ID_weekday_0002"
      },
      {
        "type": "day",
        "name": "Thursday",
        "id": "ID_weekday_0003"
      },
      {
        "type": "day",
        "name": "Friday",
        "id": "ID_weekday_0004"
      },
      {
        "type": "day",
        "name": "Saturday",
        "id": "ID_weekday_0005"
      },
      {
        "type": "day",
        "name": "Sunday",
        "id": "ID_weekday_0006"
      }
    ],
    "months": [
      {
        "name": "January",
        "type": "month",
        "length": 28,
        "interval": 1,
        "offset": 0,
        "id": "ID_month_0000"
      },
      {
        "name": "February",
        "type": "month",
        "length": 28,
        "interval": 1,
        "offset": 0,
        "id": "ID_month_0001"
      }
    ],
    "moons": [
      {
        "name": "Moon",
        "cycle": 29.333,
        "offset": 0,
        "faceColor": "#ffffff",
        "shadowColor": "#000000",
        "id": "ID_moon_0000"
      }
    ],
    "leapDays": [
      {
        "id": "ID_ic_0000",
        "name": "Good-day",
        "interval": [
          {
            "interval": 1,
            "exclusive": false,
            "ignore": false
          }
        ],
        "intercalary": true,
        "timespan": 0,
        "offset": 0,
        "type": "leapday",
        "after": 28,
        "numbered": true
      },
      {
        "id": "ID_ic_0001",
        "name": "Best-day",
        "interval": [
          {
            "interval": 1,
            "exclusive": false,
            "ignore": false
          }
        ],
        "intercalary": true,
        "timespan": 0,
        "offset": 0,
        "type": "leapday",
        "after": 28,
        "numbered": true
      }
    ],
    "eras": [
      {
        "name": "Era",
        "format": "{{era_name}}",
        "date": {
          "year": 1,
          "month": 0,
          "day": 1
        },
        "id": "ID_era_0000",
        "endsYear": false,
        "isEvent": false,
        "type": "era",
        "category": null,
        "isStartingEra": true
      }
    ]
  },
  "seasonal": {
    "seasons": [],
    "offset": 0,
    "type": "Dated",
    "displayColors": true,
    "interpolateColors": true,
    "weather": {
      "enabled": false,
      "seed": 1,
      "tempUnits": "Imperial",
      "windUnits": "Metric",
      "primaryWindDirection": "E",
      "freezingPoint": 0
    }
  },
  "locations": {
    "locations": []
  },
  "current": {
    "day": 1,
    "month": 0,
    "year": 100
  },
  "events": [],
  "id": "ID_5b08dbebbb1a",
  "categories": [],
  "dateFormat": "DDth MMM Y"
}

The rendering in Fantasy-Calendar looks liks this:

Image

The rendering in Obsidian looks like this:

Image

Which Operating Systems are you using?

  • Android
  • iPhone/iPad
  • Linux
  • macOS
  • Windows

Obsidian Version Check

1.10.6

Plugin Version

2.1.0

Confirmation

  • I have disabled all other plugins and the issue still persists.

Possible solution

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions