Skip to content

Commit 5f263e4

Browse files
authored
Fix problems in PR #76 and remerge them in, with a bump to version 1.6.4 (#79)
* Beaker vue/lib build (#76) * Changes to allow for proper building as a library and source * Packaging updates in index.ts files. * Replace `@` with relative paths. * Switch to vue-tsc for transpilation and typing fixes/updates to go along with change * Cleanup * Cleanup of issues for updating * Bump version: 1.6.3 → 1.6.4
1 parent 0a71bfb commit 5f263e4

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

57 files changed

+11518
-21366
lines changed

Makefile

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,14 @@ init:
66
make .env beaker-vue/node_modules
77

88
.PHONY:build
9-
build:
9+
build:beaker_kernel/server/ui/index.html
1010
make beaker_kernel/server/ui/index.html
1111
hatch build
1212

1313
.PHONY:clean
1414
clean:
15-
rm -r build/* dist/* beaker_kernel/server/ui/*
15+
rm -r beaker-ts/dist/* beaker-vue/dist/* build/* dist/* beaker_kernel/server/ui/* || true
16+
1617

1718
.PHONY:docs-up
1819
docs-up:
@@ -24,7 +25,7 @@ docs-down:
2425
(cd docs && docker compose down)
2526

2627
.PHONY:dev
27-
dev:
28+
dev:beaker_kernel/server/ui/index.html
2829
docker compose up -d --build && \
2930
(sleep 1; python -m webbrowser "http://localhost:8888/"); \
3031
docker compose logs -f jupyter || true; \
@@ -36,14 +37,15 @@ dev:
3637
fi
3738

3839
beaker-vue/node_modules:beaker-vue/package*.json
39-
(cd beaker-vue && npm install --dev) && \
40+
(cd beaker-ts/ && npm install --include=dev && npm run build) && \
41+
(cd beaker-vue && npm install --include=dev) && \
4042
touch beaker-vue/node_modules
4143

4244
beaker_kernel/server/ui/index.html:beaker-vue/node_modules beaker-vue/**
43-
rm -r beaker_kernel/server/ui/* ; \
45+
rm -r beaker_kernel/server/ui/* || true; \
4446
(cd beaker-ts/ && npm install && npm run build) && \
4547
(cd beaker-vue/ && npm run build) && \
46-
cp -r beaker-vue/dist/* beaker_kernel/server/ui/
48+
cp -r beaker-vue/dist/html/* beaker_kernel/server/ui/
4749

4850
.PHONY:changed-files
4951
changed-files:

beaker-ts/package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

beaker-ts/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "beaker-kernel",
3-
"version": "1.6.3",
3+
"version": "1.6.4",
44
"description": "Beaker kernel library",
55
"repository": {
66
"url": "https://github.com/jataware/beaker-kernel"

beaker-ts/src/render.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ export class BeakerRenderer {
9999
return mimetypes;
100100
}
101101

102-
public render(mimeType: MimetypeString, data: PartialJSONObject, metadata?: PartialJSONObject) {
102+
public render(mimeType: MimetypeString, data: PartialJSONObject, metadata?: PartialJSONObject): any {
103103
const renderer = this._renderers[mimeType];
104104
if (renderer) {
105105
return renderer.render(mimeType, data, metadata);

beaker-vue/.eslintrc.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,11 @@ module.exports = {
99
'@vue/typescript/recommended'
1010
],
1111
parserOptions: {
12+
warnOnUnsupportedTypeScriptVersion: false,
1213
ecmaVersion: 2020
1314
},
1415
rules: {
16+
'@typescript-eslint/no-duplicate-enum-values': 'off',
1517
'no-console': process.env.NODE_ENV === 'production' ? 'warn' : 'off',
1618
'no-debugger': process.env.NODE_ENV === 'production' ? 'warn' : 'off'
1719
}

beaker-vue/babel.config.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
module.exports = {
22
presets: [
3-
'@vue/cli-plugin-babel/preset'
4-
]
3+
'@vue/cli-plugin-babel/preset',
4+
],
5+
ignore: [
6+
/node_modules/,
7+
],
58
}

0 commit comments

Comments
 (0)