-
-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does Buku support adding images to bookmarks? #724
Comments
At this moment, only the following fields exist:
Additionally, a metadata flag "Immutable" exists, for the purpose of excluding the bookmark from batch updates. I've got some ideas on implementing extended bookmark records by adding support for custom fields (including images, at least as remote URLs); but at the moment there's no such thing and it's probably not gonna be a thing for a while. There is, however, a good chance that I'll be adding support for rendering descriptions as Markdown to the webUI (bukuserver) fairly soon; in which case, it would be possible to include an externally-hosted image. |
What do you think about having screenshots of pages with bookmarks that could be viewed in the web UI? I would help with searching. |
…Alright, I didn't quite get that. Do you mean some sort of a feature to generate such a screenshot automatically? (And storing such a screenshot in the DB as binary data, I presume?) |
Yeah, a feature to generate or get a photo of the page and show it in the web ui with the bookmark, and show the images when searching for bookmarks after entering something in the search bar (I haven't used the web ui, I'm just looking at the screenshots here: https://github.com/jarun/buku/tree/master/bukuserver#readme). |
There's a concern of size when storing images in a DB file (though using WebP and smaller resolution reduces the image size, this screenshot converted to WebP would take up about 30Kb… multiply that by the number of bookmarks you're expecting to have, and I give no promises on performance when the file is that large 😅). Using an external site (e.g. Imgur or ImageChest) for hosting images might be a better choice for such a use 🤔 That said, there's also the question of how to take such screenshots. I can name 3 possible solutions here:
I'm guessing it would be possible to implement the 1st and 2nd option (take the screenshot with JS if possible, but allow providing a user-made one as well), but the 3rd one doesn't really seem like a way to go. …Either way, this is unlikely to be supported until/unless I implement extended records. |
I did some searching and it doesn't seem to.
The text was updated successfully, but these errors were encountered: