Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circular require warning #14

Open
martindemello opened this issue Jun 4, 2023 · 2 comments
Open

circular require warning #14

martindemello opened this issue Jun 4, 2023 · 2 comments

Comments

@martindemello
Copy link
Contributor

I get a circular require warning when loading weighted_graph:

graph_matching-0.2.1/lib/graph_matching/algorithm/mwm_general.rb:3: warning: loading in progress, circular require considered harmful - graph_matching-0.2.1/lib/graph_matching/graph/weighted_graph.rb

The require in mwm_general seems to be solely for the check

        assert(graph).is_a(Graph::WeightedGraph)

so perhaps it could check for a sentinel method from Weighted instead.

@jaredbeck
Copy link
Owner

Hi Martin, Do you get this warning when running the test suite (bundle exec rspec)? If not, do you want to try reproducing this warning with a test, as a first step towards a PR?

@martindemello
Copy link
Contributor Author

no, i just tried and i don't! i get it when running tests in my own project. i'll investigate further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants