Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for deeplinks into the app #2876

Closed
julien-c opened this issue May 7, 2024 · 7 comments
Closed

feat: support for deeplinks into the app #2876

julien-c opened this issue May 7, 2024 · 7 comments
Assignees
Labels
P0: critical Mission critical Release Comms Important for the release type: feature request A new feature

Comments

@julien-c
Copy link

julien-c commented May 7, 2024

Hi! Is there a way for the Jan app to open deeplinks (like jan://) from e.g. the id for a model repo hosted on huggingface?

Would that be interesting to implement?

@julien-c julien-c added the type: feature request A new feature label May 7, 2024
@Van-QA
Copy link
Contributor

Van-QA commented May 8, 2024

@imtuyethan for future consideration
#2590
#2878

@0xSage 0xSage mentioned this issue May 8, 2024
3 tasks
@0xSage 0xSage added the P1: important Important feature / fix label May 8, 2024
@Van-QA Van-QA added this to the v. Ochazuke milestone May 8, 2024
@0xSage 0xSage added P0: critical Mission critical and removed P1: important Important feature / fix labels May 8, 2024
@Van-QA Van-QA added the Release Comms Important for the release label May 8, 2024
@Van-QA Van-QA mentioned this issue May 9, 2024
3 tasks
@Van-QA
Copy link
Contributor

Van-QA commented May 13, 2024

  1. Thank @namchuai for resolving the issue with Windows: clicking the deep link only opens the Jan app, without loading the HF modal. ✅
  2. Unfortunately, the issue is still happening on Linux ❌
  3. On the other hand, with the Jan app that already loaded deep link, updating it to a higher version will show this error toast msg ❌
    image

@Van-QA
Copy link
Contributor

Van-QA commented May 13, 2024

No 1 and No 2 are resolved as of Jan v0.4.12-416 🙏

@Van-QA
Copy link
Contributor

Van-QA commented May 13, 2024

All issues were resolved as of Jan v0.4.12-417 🙏. cc @janhq/pena for documentation
Sample URL: jan://models/huggingface/TheBloke/Magicoder-S-DS-6.7B-GGUF

@irfanpena
Copy link
Contributor

irfanpena commented May 14, 2024

@Van-QA Hi van, I just want to confirm regarding the deeplink. The template for deeplink is: jan://models/huggingface/(This is where the user can customize what model they want to import). Is this correct?

@Van-QA
Copy link
Contributor

Van-QA commented May 14, 2024

@Van-QA Hi van, I just want to confirm regarding the deeplink. The template for deeplink is: jan://models/huggingface/(This is where the user can customize what model they want to import). Is this correct?

@irfanpena, yes, and they will use the HF model id which can be collected from HF website
e.g. jan://models/huggingface/janhq/trinity-v1-GGUF
Note that HF models that have restrictions will not supported as of now (pending on #2756)

https://huggingface.co/janhq/trinity-v1-GGUF
image

In the future, Hugging Face will help us create the link in their site, users only have to click on that to import to Jan app 🙏

@irfanpena irfanpena mentioned this issue May 14, 2024
3 tasks
@julien-c
Copy link
Author

this is so awesome! can't wait to open Jan.app directly from HF model page 🥰

@Van-QA Van-QA closed this as completed May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0: critical Mission critical Release Comms Important for the release type: feature request A new feature
Projects
Archived in project
Development

No branches or pull requests

7 participants